Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): remove old GF_FEATURE_TOGGLES_ENABLE=flameGraph #3446

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

korniltsev
Copy link
Collaborator

No description provided.

@korniltsev korniltsev requested review from a team as code owners July 26, 2024 15:24
Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonswine simonswine added type/docs Improvements for doc docs. Used by Docs team for project management backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch labels Jul 31, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

1 similar comment
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@korniltsev korniltsev merged commit 857ec2e into main Jul 31, 2024
20 checks passed
@korniltsev korniltsev deleted the rmGF_FEATURE_TOGGLES_ENABLE branch July 31, 2024 17:42
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
Copy link
Contributor

The backport to release/v1.7 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3446-to-release/v1.7 origin/release/v1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 857ec2e4b24f0fe69ee48ff63ffd6c725cef0224

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3446-to-release/v1.7
# Create the PR on GitHub
gh pr create --title '[release/v1.7] fix(docs): remove old GF_FEATURE_TOGGLES_ENABLE=flameGraph' --body 'Backport 857ec2e4b24f0fe69ee48ff63ffd6c725cef0224 from #3446' --label 'type/docs' --label 'backport' --base release/v1.7 --milestone release/v1.7 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3446-to-release/v1.7

# Create a pull request where the `base` branch is `release/v1.7` and the `compare`/`head` branch is `backport-3446-to-release/v1.7`.

# Remove the local backport branch
git switch main
git branch -D backport-3446-to-release/v1.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants