Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release notes for v1.7 #3456

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Add release notes for v1.7 #3456

merged 2 commits into from
Aug 1, 2024

Conversation

aleks-p
Copy link
Contributor

@aleks-p aleks-p commented Jul 31, 2024

No description provided.

@aleks-p aleks-p requested review from a team as code owners July 31, 2024 16:32
@aleks-p aleks-p added the backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch label Jul 31, 2024
Copy link
Contributor

Hello @aleks-p!
Backport pull requests need to be either:

  • Pull requests which address bugs,
  • Urgent fixes which need product approval, in order to get merged,
  • Docs changes.

Please, if the current pull request addresses a bug fix, label it with the type/bug label.
If it already has the product approval, please add the product-approved label. For docs changes, please add the type/docs label.
If the pull request modifies CI behaviour, please add the type/ci label.
If none of the above applies, please consider removing the backport label and target the next major/minor release.
Thanks!

@aleks-p aleks-p added the type/docs Improvements for doc docs. Used by Docs team for project management label Jul 31, 2024
Copy link
Contributor

This PR must be merged before a backport PR will be created.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes for heading levels and wording. Thank you for adding the release notes!

@aleks-p aleks-p merged commit c4ed965 into main Aug 1, 2024
18 checks passed
@aleks-p aleks-p deleted the release-notes-1.7 branch August 1, 2024 12:33
github-actions bot pushed a commit that referenced this pull request Aug 1, 2024
* Add release notes for v1.7

* Apply suggestions from code review

Co-authored-by: Kim Nylander <[email protected]>

---------

Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit c4ed965)
Copy link
Contributor

github-actions bot commented Aug 1, 2024

The backport to release/v1.7 failed:

Validation Failed: "Could not resolve to a node with the global id of 'T_kwDOAG3Mbc4AczmP'."

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3456-to-release/v1.7 origin/release/v1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x c4ed96577d10d232331cad494898c8f9cefb23a5

When the conflicts are resolved, stage and commit the changes:

git add . && git cherry-pick --continue

If you have the GitHub CLI installed:

# Push the branch to GitHub:
git push --set-upstream origin backport-3456-to-release/v1.7
# Create the PR on GitHub
gh pr create --title '[release/v1.7] Add release notes for v1.7' --body 'Backport c4ed96577d10d232331cad494898c8f9cefb23a5 from #3456' --label 'type/docs' --label 'backport' --base release/v1.7 --milestone release/v1.7 --web

Or, if you don't have the GitHub CLI installed (we recommend you install it!):

# Push the branch to GitHub:
git push --set-upstream origin backport-3456-to-release/v1.7

# Create a pull request where the `base` branch is `release/v1.7` and the `compare`/`head` branch is `backport-3456-to-release/v1.7`.

# Remove the local backport branch
git switch main
git branch -D backport-3456-to-release/v1.7

aleks-p added a commit that referenced this pull request Aug 1, 2024
* Add release notes for v1.7

* Apply suggestions from code review

Co-authored-by: Kim Nylander <[email protected]>

---------

Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit c4ed965)

Co-authored-by: Aleksandar Petrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release/v1.7 This label will backport a merged PR to the release/v1.7 branch backport-failed type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants