Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pyrobench github action #3472

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

simonswine
Copy link
Contributor

@simonswine simonswine commented Aug 8, 2024

Pyrobench is a hackathon 2024-08 project, which provides a github action that can run go microbenchmarks on demand. It will:

  • Double check the code for the package with the Benchmarks in has changed (comparing base..head of PR)
  • Will run the benchmarks multiple times for base and head and then compare it using benstat (WIP).
  • Each benchmark run will also collect profiles and upload them to flamegraph.com

https://github.com/grafana/hackathon-2024-08-pyrobench (README is WIP)

Example project

grafana/hackathon-2024-08-pyrobench-dskit#1 (comment)
image

Pyrobench is a hackathon 2024-08 project, which provides a github
actiont that can run go microbenchmarks on default it will:

- Double check the code for the package with the Benchmarks in has
  changed (comparing base..head of PR)
- Will run the benchmarks multiple times for base and head and then
  compare it using benstat (WIP).
- Each benchmark run will also collect profiles and upload them to
  flamegraph.com
@simonswine simonswine marked this pull request as ready for review August 8, 2024 14:25
@simonswine simonswine requested a review from a team as a code owner August 8, 2024 14:25
@simonswine simonswine changed the title 20240808 pyrobench feat: Add pyrobench github action Aug 8, 2024
Copy link
Contributor

@bryanhuhta bryanhuhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@simonswine simonswine merged commit d876d37 into grafana:main Aug 9, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants