feat: add segment writer client #3505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korniltsev
approved these changes
Aug 21, 2024
# Conflicts: # go.sum
kolesnikovae
force-pushed
the
feat/distributor-segment-writer
branch
from
7ea333f
to
46e54a3
Compare
kolesnikovae
force-pushed
the
feat/distributor-segment-writer
branch
from
f7788f5
to
60ad16e
Compare
kolesnikovae
force-pushed
the
feat/distributor-segment-writer
branch
from
f9c119d
to
3efb5c0
Compare
kolesnikovae
force-pushed
the
feat/distributor-segment-writer
branch
from
3efb5c0
to
a16dafb
Compare
kolesnikovae
changed the title
# Conflicts: # pkg/experiment/ingester/service.go # pkg/phlare/modules_experimental.go
korniltsev
approved these changes
Aug 27, 2024
|
and sorry for merge conflicts 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3506
Closes: #199, #185 (private)
The change introduces the segment writer client and the write-path router components. A basic distribution algorithm based on jump consistent hashing was also implemented: dynamic sizing is to be implemented later.
Note that this also moves pprof-split out of the distributor – to be implemented in the segment writer in a follow-up PR.