-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Clarify which URL to use with profilecli #3526
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating the docs! Just a few minor suggestions and a clarification request.
This PR must be merged before a backport PR will be created. |
Co-authored-by: Kim Nylander <[email protected]>
(cherry picked from commit 7709a22)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-3526-to-release/v1.7 origin/release/v1.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 7709a22c080258e51efff531cb55b74750d9c209 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-3526-to-release/v1.7
# Create the PR body template
PR_BODY=$(gh pr view 3526 --json body --template 'Backport 7709a22c080258e51efff531cb55b74750d9c209 from #3526{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[release/v1.7] [docs] Clarify which URL to use with profilecli' --body-file - --label 'type/docs' --label 'backport' --base release/v1.7 --milestone release/v1.7 --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-3526-to-release/v1.7
# Create a pull request where the `base` branch is `release/v1.7` and the `compare`/`head` branch is `backport-3526-to-release/v1.7`.
# Remove the local backport branch
git switch main
git branch -D backport-3526-to-release/v1.7 |
(cherry picked from commit 7709a22) Co-authored-by: Bryan Huhta <[email protected]>
We recently ran into a case where a customer wanted to use
profilecli
but was using the wrong URL. This PR updates the docs to make it more clear which URL to use (and which one not to use).