add push input to push-to-gar-docker action
#139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
reviewed
Jun 3, 2024
| description: | | ||
| Whether to push the image to the registry. | ||
| required: false | ||
| default: "true" |
There was a problem hiding this comment.
will this work?
Suggested change
| default: "true" | |
| default: ${{ github.event_name == 'push' }} |
this is a break of backwards compatibility otherwise
There was a problem hiding this comment.
tldr; yes. good point! 👍
I pointed this build to commit 9cc5c0d, it looks like this works (this was a push event, push without being specified defaulted to true).
On this build, a pull_request event, I specified push: true and it worked as expected
|
Nice, I actually need this! |
|
is merged now --- give this one a rebase and let's see |
|
@iainlane I believe the rebase helped, it looks like the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.