Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update inputs to build-push-to-dockerhub action #143

Conversation

joeyorlando
Copy link
Contributor

@joeyorlando joeyorlando commented Jun 5, 2024

  • Adds the following inputs which are needed to migrate this Drone pipeline in grafana/oncall:
    • build-args
    • target
    • cache-to
    • cache-from
  • Modifies the action to allow pushing images to Dockerhub from all GitHub Actions event types except pull_request (previously the logic here was to only allow pushing on a build triggered from a push event)

Closes #80

@joeyorlando joeyorlando requested a review from a team as a code owner June 5, 2024 14:01
@dsotirakis
Copy link
Contributor

dsotirakis commented Jun 5, 2024

looks like you are also tackling #80 @joeyorlando. you could update the description to make sure the caching inputs updates are not missed.

@joeyorlando
Copy link
Contributor Author

@dsotirakis you mean like updating the PR's description to add the "closes <issue_number" indicator?

@dsotirakis
Copy link
Contributor

Adds build-args and target inputs which are needed to migrate

yes and also

Adds build-args and target inputs which are needed to migrate

to include caches as well

@joeyorlando
Copy link
Contributor Author

done!

dsotirakis
dsotirakis previously approved these changes Jun 6, 2024
@dsotirakis dsotirakis self-requested a review June 6, 2024 13:55
@dsotirakis dsotirakis dismissed their stale review June 6, 2024 13:56

needs one change - otherwise the flow will be broken

@joeyorlando joeyorlando requested a review from Elfo404 June 6, 2024 14:04
Copy link
Member

@Elfo404 Elfo404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@dsotirakis dsotirakis merged commit 7c79c23 into grafana:main Jun 6, 2024
3 checks passed
@joeyorlando joeyorlando deleted the jorlando/update-build-push-to-dockerhub-inputs branch June 6, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-push-to-dockerhub: Add caching options
3 participants