Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from secrets.GITHUB_TOKEN to github.token for shared workflows #146

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Switch from secrets.GITHUB_TOKEN to github.token for shared workflows #146

merged 3 commits into from
Jun 13, 2024

Conversation

ricky-undeadcoders
Copy link
Contributor

No description provided.

@ricky-undeadcoders ricky-undeadcoders requested review from a team as code owners June 11, 2024 16:09
@ricky-undeadcoders ricky-undeadcoders mentioned this pull request Jun 11, 2024
Closed
@ricky-undeadcoders ricky-undeadcoders linked an issue Jun 11, 2024 that may be closed by this pull request
Create github-app for shared workflows #138
Closed
@iainlane
Copy link
Member

Thanks! It looks plausible - maybe you can hack the if conditions so that step runs, to be sure?

@ricky-undeadcoders
Copy link
Contributor Author

ricky-undeadcoders commented Jun 12, 2024 •
edited
Loading

Thanks! It looks plausible - maybe you can hack the if conditions so that step runs, to be sure?

lint-shared-workflows did run successfully; and I was wary of running build-lint-pr because it opens a PR into main.

Update:
I created a test workflow to verify that the token also worked to open a PR. Here's the PR, and the associated action.

iainlane
iainlane approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great 👍 cheers

@ricky-undeadcoders ricky-undeadcoders merged commit 0eefcee into main Jun 13, 2024
9 checks passed
@ricky-undeadcoders ricky-undeadcoders deleted the rwhitaker/switch-gh-token branch June 13, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create github-app for shared workflows
2 participants
@ricky-undeadcoders @iainlane