fix: generate go client in a subdir #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes importing the client easier
julienduchesne
changed the title
julienduchesne
force-pushed
the
julienduchesne/generate-go-in-submodule
branch
from
ee7567c
to
4379ab0
Compare
Let's make clients more opinionated
julienduchesne
force-pushed
the
julienduchesne/generate-go-in-submodule
branch
from
4379ab0
to
d30c0b7
Compare
Duologic
approved these changes
Aug 7, 2024
spinillos
approved these changes
Aug 7, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes importing the client easier
Currently:
github.com/grafana-com-public-clients/goimports thegcompackage so it's confusing. It's a go convention that the package name should match the dir nameThis PR adds the package name to the generate path