Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup-argo): use bash, fix idempotency, only restore if needed #221

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

Duologic
Copy link
Member

@Duologic Duologic commented Aug 16, 2024

Should fix:

# OS=$(echo "$OS" | tr '[:upper:]' '[:lower:]')
/home/runner/work/_temp/69566fd1-c0c9-4966-824c-63cf829358cd.sh: 2: [[: not found

and

gzip: /home/runner/work/incident/incident/bin/argo already exists;	not overwritten

Adds a testsuite to ensure that the cache is used when it should be, and that the argo binary is set up properly on the PATH and can be run.

@Duologic Duologic requested a review from a team as a code owner August 16, 2024 09:00
- Run more steps conditionally based on whether there was a cache hit
- Fix the step name in one cases (`restore` needed to become `cache`)
- Always run the PATH step but don't add the same dir to the path twice

The last one should make the action idempotent.
@iainlane iainlane force-pushed the duologic/setup-argo-bash branch 14 times, most recently from ccd353e to 9cdf970 Compare August 16, 2024 10:46
@iainlane iainlane changed the title fix(setup-argo): use bash fix(setup-argo): use bash, fix idempotency, only restore if needed Aug 16, 2024
@zzehring zzehring added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 1e75822 Aug 16, 2024
11 checks passed
@zzehring zzehring deleted the duologic/setup-argo-bash branch August 16, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants