Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Rename push-to-dockerhub-action #33

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat: Rename push-to-dockerhub-action #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions actions/push-to-dockerhub/README.md → actions/build-push-to-dockerhub/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# push-to-dockerhub
# build-push-to-dockerhub

This is a composite GitHub Action, used to push docker images to DockerHub.
This is a composite GitHub Action, used to build Docker images and push them to DockerHub.
It uses `get-vault-secrets` action to get the DockerHub username and password from Vault.

Example of how to use this action in a repository:
Expand All @@ -20,7 +20,7 @@ jobs:

steps:
- id: push-to-dockerhub
uses: grafana/shared-workflows/actions/push-to-dockerhub@main
uses: grafana/shared-workflows/actions/build-push-to-dockerhub@main
with:
repository: ${{ github.repository }} # or any other dockerhub repository
context: .
Expand Down
6 changes: 5 additions & 1 deletion actions/push-to-dockerhub/action.yaml → actions/build-push-to-dockerhub/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ inputs:
description: |
Path to Dockerfile, which is used to build the image.
default: "."
push:
description: |
Push the generated images also to DockerHub
default: "false"

runs:
using: composite
Expand Down Expand Up @@ -45,6 +49,6 @@ runs:
uses: docker/build-push-action@3b5e8027fcad23fda98b2e3ac259d8d67585f671
with:
context: ${{ inputs.context }}
push: ${{ github.event_name == 'push' }}
push: ${{ inputs.push }}
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}