Add bundle plugin #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctively export to another package)
This reverts commit 572dab9.
|
Hey @SandersAaronD 👋 |
|
Still waiting on update from @SandersAaronD |
|
Hey folks, we've had discussions here and in other channels that this PR is considered too specialised to be included here. As a result of this PR we documented what the scope of this repository is, which was something we lacked before. I'm going to close this PR. I encourage you @SandersAaronD to find a home closer to the repos that will need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bundles a grafana plugin, which can have a backend or no backend, into a properly signed folder of zip files for both current version and "latest" which can be uploaded in order to publish the plugin. By default it zips from
./distinto__to-upload__, but both of those are configurable parameters.This workflow is structured the way it is with most logic in a sub-package to facilitate using the package as a standalone command outside of a github action if someone has a workflow that calls for that or is using this logic somewhere outside of Grafana to package a plugin.
Implemented in typescript for good portability and maintainability and to integrate well with github actions without introducing any extra dependencies (on, e.g., golang runtimes or binaries). The same thing can presently be accomplished by downloading a grabpl binary onto a machine with a golang runtime and calling it, as can be seen here.