Preallocate for review comments

grafana · Oct 25, 2023 · 40faa93 · 40faa93
1 parent e51b23d
commit 40faa93
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/tempodb/backend/azure/v1/v1.go b/tempodb/backend/azure/v1/v1.go
@@ -165,8 +165,8 @@ func (rw *V1) ListBlocks(ctx context.Context, keypath backend.KeyPath) ([]uuid.U
 	span, ctx := opentracing.StartSpanFromContext(ctx, "V1.ListBlocks")
 	defer span.Finish()
 
-	var blockIDs []uuid.UUID
-	var compactedBlockIDs []uuid.UUID
+	blockIDs := make([]uuid.UUID, 0, 1000)
+	compactedBlockIDs := make([]uuid.UUID, 0, 1000)
 
 	keypath = backend.KeyPathWithPrefix(keypath, rw.cfg.Prefix)
 

diff --git a/tempodb/backend/azure/v2/v2.go b/tempodb/backend/azure/v2/v2.go
@@ -170,8 +170,8 @@ func (rw *V2) ListBlocks(ctx context.Context, keypath backend.KeyPath) ([]uuid.U
 	span, ctx := opentracing.StartSpanFromContext(ctx, "V2.ListBlocks")
 	defer span.Finish()
 
-	var blockIDs []uuid.UUID
-	var compactedBlockIDs []uuid.UUID
+	blockIDs := make([]uuid.UUID, 0, 1000)
+	compactedBlockIDs := make([]uuid.UUID, 0, 1000)
 
 	keypath = backend.KeyPathWithPrefix(keypath, rw.cfg.Prefix)
 

diff --git a/tempodb/backend/gcs/gcs.go b/tempodb/backend/gcs/gcs.go
@@ -195,8 +195,8 @@ func (rw *readerWriter) ListBlocks(ctx context.Context, keypath backend.KeyPath)
 	span, ctx := opentracing.StartSpanFromContext(ctx, "readerWriter.ListBlocks")
 	defer span.Finish()
 
-	var blockIDs []uuid.UUID
-	var compactedBlockIDs []uuid.UUID
+	blockIDs := make([]uuid.UUID, 0, 1000)
+	compactedBlockIDs := make([]uuid.UUID, 0, 1000)
 
 	keypath = backend.KeyPathWithPrefix(keypath, rw.cfg.Prefix)
 	prefix := path.Join(keypath...)

diff --git a/tempodb/backend/s3/s3.go b/tempodb/backend/s3/s3.go
@@ -288,8 +288,8 @@ func (rw *readerWriter) ListBlocks(
 	span, ctx := opentracing.StartSpanFromContext(ctx, "readerWriter.ListBlocks")
 	defer span.Finish()
 
-	var blockIDs []uuid.UUID
-	var compactedBlockIDs []uuid.UUID
+	blockIDs := make([]uuid.UUID, 0, 1000)
+	compactedBlockIDs := make([]uuid.UUID, 0, 1000)
 
 	keypath = backend.KeyPathWithPrefix(keypath, rw.cfg.Prefix)
 	prefix := path.Join(keypath...)