Vulture fixes (#586)

* Move JaegergRPCClient outside of the write loop Signed-off-by: Daniel González Lopes <[email protected]> * Fix: increase notfound bucket instead of failed Signed-off-by: Daniel González Lopes <[email protected]> * Panic if we can instantiate a new jaegergRPC client Signed-off-by: Daniel González Lopes <[email protected]>
grafana · Mar 11, 2021 · 73546da · 73546da
1 parent f2a7f3d
commit 73546da
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/cmd/tempo-vulture/main.go b/cmd/tempo-vulture/main.go
@@ -65,17 +65,15 @@ func main() {
 
 	// Write
 	go func() {
+		c, err := newJaegerGRPCClient(tempoPushURL)
+		if err != nil {
+			panic(err)
+		}
+
 		for {
 			<-tickerWrite.C
 
 			rand.Seed((time.Now().Unix() / interval) * interval)
-			c, err := newJaegerGRPCClient(tempoPushURL)
-			if err != nil {
-				glog.Error("error creating grpc client", err)
-				metricErrorTotal.Inc()
-				continue
-			}
-
 			traceIDHigh := rand.Int63()
 			traceIDLow := rand.Int63()
 			for i := int64(0); i < generateRandomInt(1, 100); i++ {
@@ -117,7 +115,7 @@ func main() {
 			if err != nil {
 				glog.Error("error querying Tempo ", err)
 				metricErrorTotal.Inc()
-				metricTracesErrors.WithLabelValues("failed").Inc()
+				metricTracesErrors.WithLabelValues("notfound").Inc()
 				continue
 			}