Add process name attribute to vulture traces (#1127)

* Add process name attribute to vulture traces Signed-off-by: Martin Disibio <[email protected]> * Fix vulture test * changelog
grafana · Nov 18, 2021 · bd07495 · bd07495
1 parent be1550f
commit bd07495
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,6 +8,7 @@
 * [ENHANCEMENT] Include metrics for configured limit overrides and defaults: tempo_limits_overrides, tempo_limits_defaults [#1089](https://github.com/grafana/tempo/pull/1089) (@zalegrala)
 * [BUGFIX] Fix defaults for MaxBytesPerTrace (ingester.max-bytes-per-trace) and MaxSearchBytesPerTrace (ingester.max-search-bytes-per-trace) (@bitprocessor)
 * [BUGFIX] Ignore empty objects during compaction [#1113](https://github.com/grafana/tempo/pull/1113) (@mdisibio)
+* [BUGFIX] Add process name to vulture traces to work around display issues [#1127](https://github.com/grafana/tempo/pull/1127) (@mdisibio)
 
 ## v1.2.0 / 2021-11-05
 * [CHANGE] **BREAKING CHANGE** Drop support for v0 and v1 blocks. See [1.1 changelog](https://github.com/grafana/tempo/releases/tag/v1.1.0) for details [#919](https://github.com/grafana/tempo/pull/919) (@joe-elliott)

diff --git a/cmd/tempo-vulture/main_test.go b/cmd/tempo-vulture/main_test.go
@@ -16,8 +16,8 @@ import (
 
 func TestHasMissingSpans(t *testing.T) {
 	cases := []struct {
-		trace   *tempopb.Trace
-		expeted bool
+		trace    *tempopb.Trace
+		expected bool
 	}{
 		{
 			&tempopb.Trace{
@@ -61,7 +61,7 @@ func TestHasMissingSpans(t *testing.T) {
 	}
 
 	for _, tc := range cases {
-		require.Equal(t, tc.expeted, hasMissingSpans(tc.trace))
+		require.Equal(t, tc.expected, hasMissingSpans(tc.trace))
 	}
 }
 

diff --git a/cmd/tempo-vulture/testdata/trace.json b/cmd/tempo-vulture/testdata/trace.json
diff --git a/pkg/util/trace_info.go b/pkg/util/trace_info.go
@@ -146,7 +146,11 @@ func (t *TraceInfo) makeThriftBatch(TraceIDHigh int64, TraceIDLow int64) *thrift
 		})
 	}
 
-	return &thrift.Batch{Spans: spans}
+	process := &thrift.Process{
+		ServiceName: "tempo-vulture",
+	}
+
+	return &thrift.Batch{Process: process, Spans: spans}
 }
 
 func (t *TraceInfo) generateRandomString() string {