Skip to content

Commit

Permalink
tempo-mixin: remove TempoDB Access panel from Tempo / Reads, metrics …
Browse files Browse the repository at this point in the history
…don't exist anymore (#1218)

* tempo-mixin: remove TempoDB Access panel, metrics don't exist anymore

* Update CHANGELOG.md

* Forgot to increment
  • Loading branch information
kvrhdn authored Jan 17, 2022
1 parent e5a20c1 commit e1f23c2
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 303 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
* [BUGFIX] Publish tenant index age correctly for tenant index writers. [#1146](https://github.com/grafana/tempo/pull/1146) (@joe-elliott)
* [BUGFIX] Ingester startup panic `slice bounds out of range` [#1195](https://github.com/grafana/tempo/issues/1195) (@mdisibio)
* [BUGFIX] Update goreleaser install method to `go install`. [#](https://github.com/grafana/tempo/) (@mapno)
* [BUGFIX] tempo-mixin: remove TempoDB Access panel from `Tempo / Reads`, metrics don't exist anymore [#1218](https://github.com/grafana/tempo/issues/1218) (@kvrhdn)

## v1.2.1 / 2021-11-15
* [BUGFIX] Fix defaults for MaxBytesPerTrace (ingester.max-bytes-per-trace) and MaxSearchBytesPerTrace (ingester.max-search-bytes-per-trace) [#1109](https://github.com/grafana/tempo/pull/1109) (@bitprocessor)
Expand Down
17 changes: 0 additions & 17 deletions operations/tempo-mixin/dashboards/tempo-reads.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -71,23 +71,6 @@ dashboard_utils {
$.panel('Latency') +
$.latencyPanel('tempodb_backend_request_duration_seconds', '{%s,operation="GET"}' % $.jobMatcher($._config.jobs.querier))
)
)
.addRow(
g.row('TempoDB Access')
.addPanel(
g.panel('p99') +
g.queryPanel('histogram_quantile(.99, sum(rate(tempo_query_reads_bucket[$__interval])) by (layer, le))', '{{layer}}'),
)
.addPanel(
g.panel('p50') +
g.queryPanel('histogram_quantile(.5, sum(rate(tempo_query_reads_bucket[$__interval])) by (layer, le))', '{{layer}}'),
)
.addPanel(
g.panel('Bytes Read') +
g.queryPanel('histogram_quantile(.99, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))', '0.99') +
g.queryPanel('histogram_quantile(.9, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))', '0.9') +
g.queryPanel('histogram_quantile(.5, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))', '0.5'),
)
),
},
}
286 changes: 0 additions & 286 deletions operations/tempo-mixin/yamls/tempo-reads.json
Original file line number Diff line number Diff line change
Expand Up @@ -1283,292 +1283,6 @@
"showTitle": true,
"title": "Backend",
"titleSize": "h6"
},
{
"collapse": false,
"height": "250px",
"panels": [
{
"aliasColors": {

},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 13,
"legend": {
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 1,
"links": [

],
"nullPointMode": "null as zero",
"percentage": false,
"pointradius": 5,
"points": false,
"renderer": "flot",
"seriesOverrides": [

],
"spaceLength": 10,
"span": 4,
"stack": false,
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(.99, sum(rate(tempo_query_reads_bucket[$__interval])) by (layer, le))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{layer}}",
"legendLink": null,
"step": 10
}
],
"thresholds": [

],
"timeFrom": null,
"timeShift": null,
"title": "p99",
"tooltip": {
"shared": true,
"sort": 2,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": [

]
},
"yaxes": [
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": 0,
"show": true
},
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": false
}
]
},
{
"aliasColors": {

},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 14,
"legend": {
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 1,
"links": [

],
"nullPointMode": "null as zero",
"percentage": false,
"pointradius": 5,
"points": false,
"renderer": "flot",
"seriesOverrides": [

],
"spaceLength": 10,
"span": 4,
"stack": false,
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(.5, sum(rate(tempo_query_reads_bucket[$__interval])) by (layer, le))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "{{layer}}",
"legendLink": null,
"step": 10
}
],
"thresholds": [

],
"timeFrom": null,
"timeShift": null,
"title": "p50",
"tooltip": {
"shared": true,
"sort": 2,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": [

]
},
"yaxes": [
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": 0,
"show": true
},
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": false
}
]
},
{
"aliasColors": {

},
"bars": false,
"dashLength": 10,
"dashes": false,
"datasource": "$datasource",
"fill": 1,
"id": 15,
"legend": {
"avg": false,
"current": false,
"max": false,
"min": false,
"show": true,
"total": false,
"values": false
},
"lines": true,
"linewidth": 1,
"links": [

],
"nullPointMode": "null as zero",
"percentage": false,
"pointradius": 5,
"points": false,
"renderer": "flot",
"seriesOverrides": [

],
"spaceLength": 10,
"span": 4,
"stack": false,
"steppedLine": false,
"targets": [
{
"expr": "histogram_quantile(.99, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "0.99",
"legendLink": null,
"step": 10
},
{
"expr": "histogram_quantile(.9, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "0.9",
"legendLink": null,
"step": 10
},
{
"expr": "histogram_quantile(.5, sum(rate(tempo_query_bytes_read_bucket[$__interval])) by (le))",
"format": "time_series",
"intervalFactor": 2,
"legendFormat": "0.5",
"legendLink": null,
"step": 10
}
],
"thresholds": [

],
"timeFrom": null,
"timeShift": null,
"title": "Bytes Read",
"tooltip": {
"shared": true,
"sort": 2,
"value_type": "individual"
},
"type": "graph",
"xaxis": {
"buckets": null,
"mode": "time",
"name": null,
"show": true,
"values": [

]
},
"yaxes": [
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": 0,
"show": true
},
{
"format": "short",
"label": null,
"logBase": 1,
"max": null,
"min": null,
"show": false
}
]
}
],
"repeat": null,
"repeatIteration": null,
"repeatRowId": null,
"showTitle": true,
"title": "TempoDB Access",
"titleSize": "h6"
}
],
"schemaVersion": 14,
Expand Down

0 comments on commit e1f23c2

Please sign in to comment.