New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The defaults MaxBytesPerTrace and MaxSearchBytesPerTrace are broken #1110

Closed

BitProcessor opened this issue Nov 11, 2021 · 0 comments · Fixed by #1109

Contributor

BitProcessor commented Nov 11, 2021

Source:

tempo/modules/overrides/limits.go

Lines 56 to 57 in 09d52df

    
           f.IntVar(&l.MaxBytesPerTrace, "ingester.max-bytes-per-trace", 50e5, "Maximum size of a trace in bytes.  0 to disable.") 
        
           f.IntVar(&l.MaxBytesPerTrace, "ingester.max-search-bytes-per-trace", 50e3, "Maximum size of search data per trace in bytes.  0 to disable.")

As you can see, there has been a mixup in variable names:

MaxBytesPerTrace is set twice (with the latter, small incorrect value of 50000)
MaxSearchBytesPerTrace is NOT set

Fix: #1109

The text was updated successfully, but these errors were encountered:

BitProcessor mentioned this issue

Fix MaxBytesPerTrace/MaxSearchBytesPerTrace defaults #1109

Merged

3 tasks

annanay25 closed this as completed in #1109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment