Fix MaxBytesPerTrace/MaxSearchBytesPerTrace defaults #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maarten De Wispelaere <[email protected]>
Signed-off-by: Maarten De Wispelaere <[email protected]>
BitProcessor
requested review from
annanay25,
dgzlopes,
joe-elliott,
kvrhdn,
mapno and
mdisibio
as code owners
|
|
annanay25
approved these changes
Nov 11, 2021
There was a problem hiding this comment.
LGTM, bar one small nit. Thanks for the bugfix @BitProcessor!
Signed-off-by: Maarten De Wispelaere <[email protected]>
mdisibio
pushed a commit
that referenced
this pull request
Nov 15, 2021
* Fixes MaxBytesPerTrace/MaxSearchBytesPerTrace defaults Signed-off-by: Maarten De Wispelaere <[email protected]> * Fixes MaxBytesPerTrace/MaxSearchBytesPerTrace defaults Signed-off-by: Maarten De Wispelaere <[email protected]> * Fixes MaxBytesPerTrace/MaxSearchBytesPerTrace defaults Signed-off-by: Maarten De Wispelaere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maarten De Wispelaere [email protected]
What this PR does:
The defaults for
MaxBytesPerTraceandMaxSearchBytesPerTraceare broken.Fixes: #1110
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]