Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to disable the ssl cert validation on the S3 API #1182

Closed
ntimo opened this issue Dec 17, 2021 · 4 comments
Closed

Allow to disable the ssl cert validation on the S3 API #1182

ntimo opened this issue Dec 17, 2021 · 4 comments

Comments

@ntimo
Copy link

ntimo commented Dec 17, 2021

Is your feature request related to a problem? Please describe.
Currently its not possible to deploy tempo in a way where the a self hosted S3 e.g. a minio instance is secured with a certificate form a private CA. This is problematic for enterprises that use on private CAs that are then used to secure private minio instances over https.

Describe the solution you'd like
A config flag to disable the ssl cert validation

@ntimo ntimo changed the title Allow to disable the ssl cert validation on the S3 API for sel hosted minio deployments Allow to disable the ssl cert validation on the S3 API Dec 17, 2021
@trexx
Copy link

trexx commented Jan 5, 2022

You can use some Golang environment variables to override where the application looks for its ca bundles.
SSL_CERT_FILE and SSL_CERT_DIR can be used to add your private CA.

Eg: SSL_CERT_FILE=/etc/tempo/ca/ca-bundle.pem

Or merge / replace the OS trusted ca bundle.

@zalegrala
Copy link
Contributor

It looks like this is currently possible when using minio/s3.

https://github.com/grafana/tempo/blob/main/tempodb/backend/s3/config.go#L15

Though, if you have TLS enabled on the server side and also have the capability to inject the CA cert into the environment as @trexx suggests, that might be a better alternative.

Does the configuration option work for your situation here?

@trexx
Copy link

trexx commented Jan 25, 2022

I've just tried this, and the flag in fact disables https entirely and forces http. It does not just disable certificate verification.
It still maybe necessary to use the env var or mount a ca-bundle over /etc/ssl/certs/ca-certificates.crt

https://github.com/grafana/tempo/blob/v1.3.0/tempodb/backend/s3/s3.go
https://github.com/minio/minio-go/blob/master/transport.go

@mdisibio
Copy link
Contributor

Fixed in a duplicate issue: #1466

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants