Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3: add insecure_skip_verify to enable TLS without verifying the certificate #1466

Closed
kvrhdn opened this issue Jun 2, 2022 · 0 comments · Fixed by #1470
Closed

s3: add insecure_skip_verify to enable TLS without verifying the certificate #1466

kvrhdn opened this issue Jun 2, 2022 · 0 comments · Fixed by #1470
Assignees

Comments

@kvrhdn
Copy link
Member

kvrhdn commented Jun 2, 2022

Is your feature request related to a problem? Please describe.
The s3 config block supports an insecure parameter which disables TLS completely. For environments with self-signed certificates it would be nice to support insecure_skip_verify as well. This would enable TLS but not verify the certificate.

Describe the solution you'd like
Add insecure_skip_verify to not verify certificates.

Describe alternatives you've considered
You can probably work around this by adding the self-signed certificates to your authority store, but this isn't always straight-forward.

Additional context
Example code to achieve this using minio-go: minio/minio-go#1019 (comment)

fyi, Loki has this option: https://github.com/grafana/loki/blob/main/pkg/storage/bucket/http/config.go#L12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants