-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vulture fixes #586
Merged
joe-elliott
merged 3 commits into
grafana:master
from
dgzlopes:fix-vulture-goroutine-leak
Mar 11, 2021
Merged
Vulture fixes #586
joe-elliott
merged 3 commits into
grafana:master
from
dgzlopes:fix-vulture-goroutine-leak
Mar 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgzlopes
requested review from
annanay25,
joe-elliott and
mdisibio
as code owners
March 11, 2021 10:25
dgzlopes
force-pushed
the
fix-vulture-goroutine-leak
branch
from
March 11, 2021 10:25
e9536f6
to
1a6f9cb
Compare
joe-elliott
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might be easier to wrap this in function and use defer...but no big deal either way
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
dgzlopes
force-pushed
the
fix-vulture-goroutine-leak
branch
from
March 11, 2021 17:41
1a6f9cb
to
dce8c75
Compare
dgzlopes
commented
Mar 11, 2021
Signed-off-by: Daniel González Lopes <[email protected]>
joe-elliott
approved these changes
Mar 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
failed
tonotfound
)Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]