-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reload search blocks and replay search WAL #1000
Conversation
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
PR #1000! |
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Annanay <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close to LGTM. Left a few comments.
Signed-off-by: Annanay <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
…lock encoding Signed-off-by: Martin Disibio <[email protected]>
…lock encoding Signed-off-by: Martin Disibio <[email protected]>
…essary Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
@@ -269,6 +270,53 @@ func testAppendReplayFind(t *testing.T, e backend.Encoding) { | |||
require.NoError(t, err) | |||
} | |||
|
|||
func TestParseFileName(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had a test for ParseFileName
in append_block_test.go
. But no worries, we can club the two in a later PR
|
||
} | ||
|
||
func BenchmarkBackendSearchBlockSearch(b *testing.B) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdisibio did you intend to relocate this test as well?
What this PR does:
StreamingSearchBlock
. See benchmark numbers below for each encoding/compression format.BackendSearchBlock
sAppendBlock
andStreamingSearchBlock
also
Which issue(s) this PR fixes:
Fixes part of #932
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]