Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process name attribute to vulture traces #1127

Merged
merged 3 commits into from
Nov 18, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* [ENHANCEMENT] Include metrics for configured limit overrides and defaults: tempo_limits_overrides, tempo_limits_defaults [#1089](https://github.com/grafana/tempo/pull/1089) (@zalegrala)
* [BUGFIX] Fix defaults for MaxBytesPerTrace (ingester.max-bytes-per-trace) and MaxSearchBytesPerTrace (ingester.max-search-bytes-per-trace) (@bitprocessor)
* [BUGFIX] Ignore empty objects during compaction [#1113](https://github.com/grafana/tempo/pull/1113) (@mdisibio)
* [BUGFIX] Add process name to vulture traces to work around display issues [#1127](https://github.com/grafana/tempo/pull/1127) (@mdisibio)

## v1.2.0 / 2021-11-05
* [CHANGE] **BREAKING CHANGE** Drop support for v0 and v1 blocks. See [1.1 changelog](https://github.com/grafana/tempo/releases/tag/v1.1.0) for details [#919](https://github.com/grafana/tempo/pull/919) (@joe-elliott)
Expand Down
6 changes: 3 additions & 3 deletions cmd/tempo-vulture/main_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ import (

func TestHasMissingSpans(t *testing.T) {
cases := []struct {
trace *tempopb.Trace
expeted bool
trace *tempopb.Trace
expected bool
}{
{
&tempopb.Trace{
Expand Down Expand Up @@ -61,7 +61,7 @@ func TestHasMissingSpans(t *testing.T) {
}

for _, tc := range cases {
require.Equal(t, tc.expeted, hasMissingSpans(tc.trace))
require.Equal(t, tc.expected, hasMissingSpans(tc.trace))
}
}

Expand Down
2 changes: 1 addition & 1 deletion cmd/tempo-vulture/testdata/trace.json

Large diffs are not rendered by default.

6 changes: 5 additions & 1 deletion pkg/util/trace_info.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,11 @@ func (t *TraceInfo) makeThriftBatch(TraceIDHigh int64, TraceIDLow int64) *thrift
})
}

return &thrift.Batch{Spans: spans}
process := &thrift.Process{
ServiceName: "tempo-vulture",
}

return &thrift.Batch{Process: process, Spans: spans}
}

func (t *TraceInfo) generateRandomString() string {
Expand Down