Gogoproto coded etcd #1260
Merged
Gogoproto coded etcd #1260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-elliott
reviewed
Jan 31, 2022
pkg/gogocodec/gogocodec.go
Outdated
| @@ -23,6 +23,7 @@ const ( | |||
| jaegerProtoGenPkgPath = "github.com/jaegertracing/jaeger/proto-gen" | |||
| jaegerModelPkgPath = "github.com/jaegertracing/jaeger/model" | |||
| otelProtoPkgPath = "go.opentelemetry.io/collector" | |||
| etcdProtoPkgPath = "go.etcd.io/etcd/api/v3/etcdserverpb" | |||
There was a problem hiding this comment.
nice fix, but i'm wondering if we can just update our etcd dependency instead of adding it here?
does the most recent etcd support latest grpc/proto?
also, we will definitely need to cut a 1.3.1 with this. good catch.
There was a problem hiding this comment.
The gogocodec hack for etcd can be removed once it's upgraded to grpc >v1.38 is released (tentatively next release from v3.5.1). We're stuck with this for a bit I'm afraid.
There was a problem hiding this comment.
FWIW, it's updated in main, but still unreleased
joe-elliott
reviewed
Jan 31, 2022
annanay25
reviewed
Feb 1, 2022
mapno
force-pushed
the
gogoproto-coded-etcd
branch
from
cccf382
to
d021495
Compare
mapno
requested review from
dgzlopes,
kvrhdn,
mdisibio and
zalegrala
as code owners
mapno
force-pushed
the
gogoproto-coded-etcd
branch
from
7ca0e06
to
022ded6
Compare
mapno
force-pushed
the
gogoproto-coded-etcd
branch
from
c85352f
to
a6dccd2
Compare
joe-elliott
reviewed
Feb 2, 2022
| // wait for active ingesters | ||
| time.Sleep(1 * time.Second) | ||
| matchers := []*labels.Matcher{ | ||
| func TestMicroservicesWithKVStores(t *testing.T) { |
mapno
added a commit
that referenced
this pull request
Feb 2, 2022
* Register etcd's server proto path in gogoproto codec * Upgrade etcd api patch version and add changelog entry * Extend e2e to test all kv stores * Serverles go mod tidy * Typo * Config hostname from suite * Remove docker namespace from hostname
mapno
added a commit
that referenced
this pull request
Feb 2, 2022
* Register etcd's server proto path in gogoproto codec * Upgrade etcd api patch version and add changelog entry * Extend e2e to test all kv stores * Serverles go mod tidy * Typo * Config hostname from suite * Remove docker namespace from hostname
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Registers etcd's server proto in gogoproto codec
Which issue(s) this PR fixes:
Fixes #1213
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]