Prevent data race by using xxhash instance as a local variable #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikashmishra100
requested review from
joe-elliott,
annanay25,
mdisibio,
dgzlopes,
mapno,
kvrhdn and
zalegrala
as code owners
|
|
joe-elliott
reviewed
Apr 14, 2022
|
Thank you. Added the change log entry. |
mdisibio
reviewed
Apr 14, 2022
tempodb/encoding/v2/appender.go
Outdated
| a.hash.Reset() | ||
| _, _ = a.hash.Write(id) | ||
| hash := a.hash.Sum64() | ||
| hasher := xxhash.New() |
There was a problem hiding this comment.
fwiw - I think we could keep the static hash for writes and just alloc a new one for reads.
There was a problem hiding this comment.
yeah, that's fair. it's a small improvement, but this code is called constantly.
There was a problem hiding this comment.
I have updated the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
A shared instance of xxhash causes a data race and crash in the ingester. This PR fixes by converting the shared instance to a local variable.
Which issue(s) this PR fixes:
Fixes #1384
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]