Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DNS address fully qualified to reduce DNS lookups in Kubernetes #1687

Merged
merged 3 commits into from
Aug 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* [ENHANCEMENT] metrics-generator: expose span size as a metric [#1662](https://github.com/grafana/tempo/pull/1662) (@ie-pham)
* [ENHANCEMENT] Set Max Idle connections to 100 for Azure, should reduce DNS errors in Azure [#1632](https://github.com/grafana/tempo/pull/1632) (@electron0zero)
* [CHANGE] Make DNS address fully qualified to reduce DNS lookups in Kubernetes [#1687](https://github.com/grafana/tempo/pull/1687) (@electron0zero)

## v1.5.0 / 2022-08-17

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator_enabled: false
overrides:
per_tenant_override_config: /overrides/overrides.yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator_enabled: false
overrides:
per_tenant_override_config: /overrides/overrides.yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator_enabled: false
overrides:
per_tenant_override_config: /overrides/overrides.yaml
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator:
storage:
path: /var/tempo/generator_wal
Expand Down
4 changes: 2 additions & 2 deletions operations/jsonnet-compiled/ConfigMap-tempo-querier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator_enabled: false
overrides:
per_tenant_override_config: /overrides/overrides.yaml
querier:
frontend_worker:
frontend_address: query-frontend-discovery.tracing.svc.cluster.local:9095
frontend_address: query-frontend-discovery.tracing.svc.cluster.local.:9095
search_enabled: false
server:
http_listen_port: 3200
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ data:
abort_if_cluster_join_fails: false
bind_port: 7946
join_members:
- gossip-ring.tracing.svc.cluster.local:7946
- gossip-ring.tracing.svc.cluster.local.:7946
metrics_generator_enabled: false
overrides:
per_tenant_override_config: /overrides/overrides.yaml
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet-compiled/Deployment-compactor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
template:
metadata:
annotations:
config_hash: 39135b35e93010b0064838bd8f37a47f
config_hash: 04977ed074a986f446c93be0dbcd59cc
labels:
app: compactor
name: compactor
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet-compiled/Deployment-distributor.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
template:
metadata:
annotations:
config_hash: 1419befab9a6b69d88896bd1f4394654
config_hash: b18e8715d189e60852d11f32653473a9
labels:
app: distributor
name: distributor
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
template:
metadata:
annotations:
config_hash: 38371b26593e9c469c05ce32310ccdc9
config_hash: 264025c7ed58d6666fe3c7278e8993f2
labels:
app: metrics-generator
name: metrics-generator
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet-compiled/Deployment-querier.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
template:
metadata:
annotations:
config_hash: a584f6c6479c64143d0008609e0b0c25
config_hash: 15acd5511dbb9b46b5e58e3fa1059843
labels:
app: querier
name: querier
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ spec:
template:
metadata:
annotations:
config_hash: 345364f17b5771460510d3d5b9028e3c
config_hash: df848edaed79a9620eb44a18be4ce4f5
labels:
app: query-frontend
name: query-frontend
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet-compiled/StatefulSet-ingester.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
template:
metadata:
annotations:
config_hash: 345364f17b5771460510d3d5b9028e3c
config_hash: df848edaed79a9620eb44a18be4ce4f5
labels:
app: ingester
name: ingester
Expand Down
6 changes: 3 additions & 3 deletions operations/jsonnet-compiled/util/jsonnetfile.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@
"subdir": "ksonnet-util"
}
},
"version": "1aa353b7afc7ce46351b88d52235ae7a17f4ec0e",
"sum": "QiIOYQ0mdyVXStdPxu99M5CYGtYAXczWAC62EAQmWBM="
"version": "c132c4afcf17491718539db4c2d94c0ea4346120",
"sum": "2++XoPslyz02LRgsxREWxjLgYgiCIqhAtXCyVSvYcoE="
},
{
"source": {
Expand All @@ -18,7 +18,7 @@
"subdir": "memcached"
}
},
"version": "1aa353b7afc7ce46351b88d52235ae7a17f4ec0e",
"version": "c132c4afcf17491718539db4c2d94c0ea4346120",
"sum": "8hXTN4QOMkpad75LESkdfRD4/Sl81fMqZcD0ZPx2SNc="
},
{
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions operations/jsonnet/microservices/configmap.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
memberlist: {
abort_if_cluster_join_fails: false,
bind_port: $._config.gossip_ring_port,
join_members: ['gossip-ring.%s.svc.cluster.local:%d' % [$._config.namespace, $._config.gossip_ring_port]],
join_members: ['gossip-ring.%s.svc.cluster.local.:%d' % [$._config.namespace, $._config.gossip_ring_port]],
},
},

Expand Down Expand Up @@ -107,7 +107,7 @@
},
querier+: {
frontend_worker+: {
frontend_address: 'query-frontend-discovery.%s.svc.cluster.local:9095' % [$._config.namespace],
frontend_address: 'query-frontend-discovery.%s.svc.cluster.local.:9095' % [$._config.namespace],
},
},
},
Expand Down