Update opentelemetry-proto to v0.18.0 #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
kvrhdn and
zalegrala
as code owners
zalegrala
approved these changes
Sep 26, 2022
|
Nice work. Per @zalegrala's comment please highlight that the breaking change impacts the trace by id endpoint if json is requested. (and whatever else it breaks) |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updates
opentelemetry-protosubmodule from v0.8.0 to v0.18.0. v0.18.0 is the latest version that still contains the deprecated fieldsinstrumentation_library..., which were replaced byscope.... All internal types have been updated to use scope fields.For Tempo, this means that the query by ID API will return the new format (scope-based naming), both in JSON and protobuf. This is a breaking change for JSON.
Which issue(s) this PR fixes:
Contributes to #1746
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]