Extend /flush to support flushing a single tenant #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrhdn
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno and
zalegrala
as code owners
kvrhdn
changed the title
mapno
reviewed
Mar 27, 2023
Good point! I used |
mapno
approved these changes
Mar 29, 2023
zalegrala
approved these changes
Apr 6, 2023
|
Oops, forgot about this one 🙃 |
|
@kvrhdn Do we want to backport the docs for this change to the Tempo 2.1 release? Your doc updates don't appear to be in the 2.1 docs. |
|
If it's not too much work, backporting this would be good. Not super critical imo, this addition to the endpoint has a very narrow use-case, so I doubt a lot of people if any will use this outside of us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
/flushwill flush data for all the tenants, this PR extends the endpoint to also support/flush?instance=.... Flushing the data of single tenant can be useful in case you need to work on data of that single tenant.Which issue(s) this PR fixes:
Fixes #Checklist
Tests updatedCHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]