Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports ranger operators for strings in TraceQL #2321

Merged
merged 8 commits into from
Apr 21, 2023
Merged

Supports ranger operators for strings in TraceQL #2321

merged 8 commits into from
Apr 21, 2023

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Apr 10, 2023

What this PR does: Supports ranger operators for strings in TraceQL

Which issue(s) this PR fixes:
Fixes #2181

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@knylander-grafana
Copy link
Contributor

@ie-pham Do we need to update the doc for ranger operators?

@ie-pham ie-pham changed the title Supports ranger operators for strings in TraceQL [wip]Supports ranger operators for strings in TraceQL Apr 11, 2023
@ie-pham ie-pham changed the title [wip]Supports ranger operators for strings in TraceQL Supports ranger operators for strings in TraceQL Apr 18, 2023
@ie-pham
Copy link
Contributor Author

ie-pham commented Apr 18, 2023

@mdisibio not sure how to do byte compare because it needs match the query type?

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs! Doc changes look good.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

CHANGELOG.md Outdated Show resolved Hide resolved
docs/sources/tempo/traceql/_index.md Outdated Show resolved Hide resolved
@ie-pham ie-pham merged commit c6b269c into grafana:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TraceQL] Support range operators for strings
3 participants