Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement polling improvements #2652
Implement polling improvements #2652
Changes from 143 commits
12710ce
92e6ba8
a5bb5f7
59eb3b3
1ba21d8
2e5b0da
8146c5f
c8eb1c1
3c3b149
cfb4ab0
fb8993b
d6cecc8
0c1ee7b
59cb36f
c4ddeaa
755926d
bcb359e
ddaa258
925d73d
adbe16a
97cb6ad
810e932
3ce562a
10c6e22
0960935
35ee13d
efa8b5d
43d501a
2f4ca7f
4df1a4d
f81fe24
07c81b0
b9fa456
9595ace
be7165c
41a4221
54cc938
a651356
14b4844
b50457e
2a37214
2b8ff47
7c0cbc4
973f57a
8fea99a
7bcaca6
a1ade3e
f28cfb8
acbc9dc
b0ebb3a
d480514
a9ac89d
9007e2b
069d98c
4132775
344fd42
8e78f64
75d029c
9d44a7b
c6ed469
9ae8912
e886fbf
1a77bec
3154a8a
42049f0
1385d49
9e3b881
566d696
d3748ef
0150bc9
083b0e1
2ad5ebf
3110006
fbf7365
7e5e1df
5d4deed
40b948a
e26b0a8
a304e0c
181ef66
c1e22d6
469873c
30f5bca
2cb127b
fc2f45f
d30429f
f07e28c
2f232c2
3e9b5ac
dc38e63
7f13587
32ff2e1
9742b00
818be36
37a5d0d
b93ccb2
525e2af
0f6824d
6f8c00e
b113afa
d523b4c
5d82697
1ea496b
eead2be
d5ba41b
7044431
bf65ef2
4719d5b
78dbb23
ca5c83f
762ca7e
bc12f1e
8b5845d
a7a9a83
d392115
35e8570
0544845
f24c37e
f3447ac
63c9bf2
d65450e
9d3b064
e3c1aab
cb8d2a6
4e54cc1
2703973
7585b5a
56ded80
30f63f8
e51b23d
40faa93
a8a9035
7a877ba
b805fb8
aeaba0a
d0c3fdd
c080db0
0a4fdd9
89f4a68
15855f4
2cffd49
983612b
2173034
d2b7009
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm rethinking this and perhaps a default of
1
is better here. Thoughts?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you envision this setting will be in a large cluster with 100k+ blocks? i think 3-5 as a default makes sense. it will help smaller clusters grow w/o putting a huge burden on the tenant index builders
i suppose a goal would be to pick a default where an average user will not see a change in behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had tested with 20 on gcs and got the best performance, but this was not running with the large number of instances we see in some of our environments. The good thing is that we have a configuration option to tune. I'm fine with coming out the gate with 3 and then finding a nice balance as we roll this out, then come back and adjust our defaults if it turns out we were way off.