[Traceql Metrics] PR 2 - API #3252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
force-pushed
the
traceql-metrics-2-api
branch
from
7beefd9
to
4907c5c
Compare
3 tasks
zalegrala
force-pushed
the
traceql-metrics-2-api
branch
from
874625e
to
269cc45
Compare
This was referenced Dec 21, 2023
mdisibio
requested review from
joe-elliott,
annanay25,
mapno and
yvrhdn
as code owners
mdisibio
requested review from
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
3 tasks
mdisibio
commented
Jan 11, 2024
| @@ -305,7 +304,7 @@ func newSpansetFilter(e FieldExpression) *SpansetFilter { | |||
| func (*SpansetFilter) __spansetExpression() {} | |||
|
|
|||
| func (f *SpansetFilter) evaluate(input []*Spanset) ([]*Spanset, error) { | |||
| f.outputBuffer = f.outputBuffer[:0] | |||
| var outputBuffer []*Spanset | |||
There was a problem hiding this comment.
This change is required to make the traceql eval callback safe for concurrent use (so we can execute the query against multiple blocks in parallel). This was ok previously because: regular searches were single threaded or the query was compiled for each block and they got their own AST (and SpansetFilters). But now for metrics the AST keeps more state and it should be more efficient to reuse the same AST across all blocks. Otherwise it would have to create and squash repeatedly the same timeseries from each block to get the final results.
zalegrala
reviewed
Jan 11, 2024
mdisibio
commented
Jan 11, 2024
… on first error and cancel any remaining work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This is the result of a collaboration effort and requires #3227 for the underlying work of providing the data. Here we build out the API for metrics in Tempo.
Notes
This is one entry in a set of chained PRs. The full body of work has been split into separate buckets to make reviews and updates more manageable.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]