Read path for RF1 generator blocks [3 of 3] #3723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mapno
force-pushed
the
rf1-read-path
branch
2 times, most recently
from
cabb7ef
to
0bc707b
Compare
mapno
requested review from
joe-elliott,
annanay25,
mdisibio,
kvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mdisibio
reviewed
May 31, 2024
| @@ -628,6 +628,10 @@ func optimize(req *FetchSpansRequest) { | |||
| req.SecondPassConditions = nil | |||
| } | |||
| } | |||
|
|
|||
| if len(req.SecondPassConditions) == 0 { | |||
There was a problem hiding this comment.
Note: This fixes a performance regression unrelated to this PR.
mdisibio
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Follow-up to #3691.
Adds the ability to query generator blocks (RF=1) for TraceQL metrics. If
frontend.metrics.query_generator_blocksis set to true, the frontend will use the new query path and build requests only targeting blocks withReplicationFactor=1.This allows for more efficient query sharding—because there's no need to dedup data, querier jobs can target blocks or portions of them, instead of each job opening all blocks.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]