[DOC] Add missing doc for metrics #3726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knylander-grafana
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
mdisibio
reviewed
May 29, 2024
| These functions can be added as an operator at the end of any TraceQL query. | ||
|
|
||
| `rate` | ||
| : Provides the percentage of |
There was a problem hiding this comment.
What does rate actually do? I was trying to figure out the best way to define it.
There was a problem hiding this comment.
Rate is like count_over_time, but normalized to spans per second. They are based on the granularity of the step parameter in the request. If your step is 1 minute, then rate = count_over_time / 60 (there are 60 seconds in a minute).
Co-authored-by: Martin Disibio <[email protected]>
mdisibio
reviewed
May 30, 2024
Co-authored-by: Martin Disibio <[email protected]>
|
This PR must be merged before a backport PR will be created. |
mdisibio
approved these changes
May 30, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
* Add missing doc for metrics * Update docs/sources/tempo/operations/traceql-metrics.md * Apply suggestions from code review Co-authored-by: Martin Disibio <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Martin Disibio <[email protected]> --------- Co-authored-by: Martin Disibio <[email protected]> (cherry picked from commit 56a0b8c)
3 tasks
knylander-grafana
added a commit
that referenced
this pull request
May 31, 2024
* [DOC] Add missing doc for metrics (#3726) * Add missing doc for metrics * Update docs/sources/tempo/operations/traceql-metrics.md * Apply suggestions from code review Co-authored-by: Martin Disibio <[email protected]> * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Martin Disibio <[email protected]> --------- Co-authored-by: Martin Disibio <[email protected]> (cherry picked from commit 56a0b8c) * Update docs/sources/tempo/operations/traceql-metrics.md --------- Co-authored-by: Kim Nylander <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds missing doc for quantile_over_time, histrogram, and rate.
Related: #3605, #3633, #3644
Questions for reviewers:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]