TraceQL link intrinsic link:traceID and link:spanID #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoewer
force-pushed
the
traceql-additions-link-intrinsics
branch
from
1de8379
to
18440f2
Compare
stoewer
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero and
ie-pham
as code owners
mapno
approved these changes
May 31, 2024
|
Will we need doc for this? |
mdisibio
reviewed
May 31, 2024
| @@ -781,10 +785,13 @@ func checkConditions(conditions []traceql.Condition) error { | |||
| } | |||
|
|
|||
| // Check for conditions that are not supported in vParquet2 | |||
| if cond.Attribute.Intrinsic == traceql.IntrinsicEventName { | |||
| if cond.Attribute.Intrinsic == traceql.IntrinsicEventName || | |||
There was a problem hiding this comment.
At some point I would like to swap checkConditions to look for supported things, instead of unsupported things. Which is less brittle going forward.
There was a problem hiding this comment.
I agree, it would be safer to check what is supported. I've made a note for myself to refactor this in a separate PR
mdisibio
reviewed
May 31, 2024
| @@ -1458,43 +1505,59 @@ func createAllIterator(ctx context.Context, primaryIter parquetquery.Iterator, c | |||
| var ( | |||
| // If there are only span conditions, then don't return a span upstream | |||
| // unless it matches at least 1 span-level condition. | |||
| spanRequireAtLeastOneMatch = len(spanConditions) > 0 && len(resourceConditions) == 0 && len(traceConditions) == 0 | |||
| spanRequireAtLeastOneMatch = len(catConditions.span) > 0 && len(catConditions.resource) == 0 && len(catConditions.trace) == 0 | |||
There was a problem hiding this comment.
Just fyi that these are removed in: #3734
There was a problem hiding this comment.
Thanks for the heads up. I've resolved the conflicts 👍
Yes, we should have documentation for all TraceQL extensions. I added a documentation sub-task to the TraceQL additions epic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add
linkscope and the intrinsicslink:traceIDandlink:spanID.Autocomplete is currently not working, but is also part of a separate issue.
Which issue(s) this PR fixes:
Contributes to grafana/tempo-squad#433)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]