Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change trace-level iterators to push predicates down for all queries #3920

Merged
merged 2 commits into from
Jul 30, 2024
Merged

Change trace-level iterators to push predicates down for all queries #3920

merged 2 commits into from
Jul 30, 2024

Conversation

mdisibio
Copy link
Contributor

What this PR does:
This PR updates the trace-level iterators to push down predicates for all queries, even where AllConditions=false. An example query is { rootServiceName = "tempo-gateway" && (status = error || span.http.status_code = 500)}. This wasn't actually filtering for "tempo-gateway" at the fetch layer.

The reason this wasn't done before was interaction with metadata on search responses. If the query was already using a metadata column (i.e root service name), we didn't want to read it again. But this meant that queries like above had to be reverted to do no filtering in the fetch layer, and pass everything up to the engine.

By updating the metadata second pass to be a bit more precise and splitting it out better, we can let those predicates be pushed down, and then read the column a second time (only for the search hits). This gains a lot of cpu/mem improvement, for a little bit more i/o. I think it's a worthwhile tradeoff.

This PR has a little improvement for other query types too, because the join in createTraceIterator was changed. Previously it was pulling the first page of each column before checking for hits on the inner iterator, because it was a Join and not a LeftJoin.

Query_range is unaffected in the current benchmarks because none of them have a metadata column in the second pass. But this will be important for #3824

BenchmarkTraceQL 
                                                 │ before.txt  │              after.txt              │
                                                 │   sec/op    │   sec/op     vs base                │
BackendBlockTraceQL/spanAttValMatch                78.04m ± 1%   77.35m ± 1%   -0.88% (p=0.011 n=10)
BackendBlockTraceQL/spanAttValNoMatch              1.955m ± 0%   1.833m ± 0%   -6.26% (p=0.000 n=10)
BackendBlockTraceQL/spanAttIntrinsicMatch          42.60m ± 1%   42.13m ± 1%        ~ (p=0.105 n=10)
BackendBlockTraceQL/spanAttIntrinsicNoMatch        1.547m ± 0%   1.444m ± 1%   -6.63% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttValMatch            330.0m ± 1%   328.8m ± 1%        ~ (p=0.075 n=10)
BackendBlockTraceQL/resourceAttValNoMatch          1.604m ± 0%   1.455m ± 0%   -9.28% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch      11.91m ± 1%   11.92m ± 0%        ~ (p=0.912 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch#01   1.582m ± 1%   1.433m ± 0%   -9.40% (p=0.000 n=10)
BackendBlockTraceQL/traceOrMatch                   314.7m ± 0%   228.6m ± 1%  -27.34% (p=0.000 n=10)
BackendBlockTraceQL/traceOrNoMatch                 302.3m ± 2%   222.5m ± 1%  -26.39% (p=0.000 n=10)
BackendBlockTraceQL/mixedValNoMatch                100.9m ± 0%   100.5m ± 0%   -0.42% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchAnd          1.644m ± 0%   1.609m ± 1%   -2.14% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchOr           100.5m ± 0%   100.3m ± 2%        ~ (p=0.143 n=10)
BackendBlockTraceQL/count                          277.4m ± 1%   276.4m ± 2%        ~ (p=0.739 n=10)
BackendBlockTraceQL/struct                         383.9m ± 1%   384.5m ± 1%        ~ (p=0.971 n=10)
BackendBlockTraceQL/||                             115.1m ± 1%   114.3m ± 1%        ~ (p=0.353 n=10)
BackendBlockTraceQL/mixed                          33.54m ± 1%   33.54m ± 1%        ~ (p=0.912 n=10)
BackendBlockTraceQL/complex                        2.016m ± 1%   1.912m ± 0%   -5.13% (p=0.000 n=10)
geomean                                            28.26m        26.63m        -5.76%

                                                 │  before.txt   │              after.txt               │
                                                 │      B/s      │     B/s       vs base                │
BackendBlockTraceQL/spanAttValMatch                 183.9Mi ± 1%   185.6Mi ± 1%   +0.89% (p=0.011 n=10)
BackendBlockTraceQL/spanAttValNoMatch              1001.9Mi ± 0%   933.0Mi ± 0%   -6.88% (p=0.000 n=10)
BackendBlockTraceQL/spanAttIntrinsicMatch           351.8Mi ± 1%   355.8Mi ± 1%        ~ (p=0.105 n=10)
BackendBlockTraceQL/spanAttIntrinsicNoMatch         914.2Mi ± 0%   806.6Mi ± 1%  -11.77% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttValMatch             42.89Mi ± 1%   43.04Mi ± 1%        ~ (p=0.078 n=10)
BackendBlockTraceQL/resourceAttValNoMatch           262.9Mi ± 0%   118.6Mi ± 0%  -54.89% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch       1.032Gi ± 1%   1.032Gi ± 0%        ~ (p=0.912 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch#01    288.3Mi ± 1%   144.5Mi ± 0%  -49.90% (p=0.000 n=10)
BackendBlockTraceQL/traceOrMatch                    41.29Mi ± 0%   56.87Mi ± 1%  +37.73% (p=0.000 n=10)
BackendBlockTraceQL/traceOrNoMatch                  3.667Mi ± 2%   3.901Mi ± 1%   +6.37% (p=0.000 n=10)
BackendBlockTraceQL/mixedValNoMatch                 22.10Mi ± 0%   19.71Mi ± 0%  -10.79% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchAnd           264.0Mi ± 0%   115.0Mi ± 1%  -56.46% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchOr            151.8Mi ± 0%   152.1Mi ± 2%        ~ (p=0.138 n=10)
BackendBlockTraceQL/count                           50.95Mi ± 1%   51.15Mi ± 2%        ~ (p=0.739 n=10)
BackendBlockTraceQL/struct                          41.08Mi ± 1%   41.02Mi ± 1%        ~ (p=0.987 n=10)
BackendBlockTraceQL/||                              123.6Mi ± 1%   124.4Mi ± 1%        ~ (p=0.353 n=10)
BackendBlockTraceQL/mixed                           417.0Mi ± 1%   416.9Mi ± 1%        ~ (p=0.912 n=10)
BackendBlockTraceQL/complex                         884.0Mi ± 1%   806.1Mi ± 1%   -8.82% (p=0.000 n=10)
geomean                                             154.8Mi        136.2Mi       -12.02%

                                                 │  before.txt  │               after.txt               │
                                                 │   MB_io/op   │  MB_io/op    vs base                  │
BackendBlockTraceQL/spanAttValMatch                  15.05 ± 0%    15.05 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/spanAttValNoMatch                2.054 ± 0%    1.793 ± 0%  -12.71% (p=0.000 n=10)
BackendBlockTraceQL/spanAttIntrinsicMatch            15.72 ± 0%    15.72 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/spanAttIntrinsicNoMatch          1.483 ± 0%    1.221 ± 0%  -17.67% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttValMatch              14.84 ± 0%    14.84 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/resourceAttValNoMatch           442.0m ± 0%   180.9m ± 0%  -59.07% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch        13.21 ± 0%    13.21 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/resourceAttIntrinsicMatch#01    478.2m ± 0%   217.1m ± 0%  -54.60% (p=0.000 n=10)
BackendBlockTraceQL/traceOrMatch                     13.63 ± 0%    13.63 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/traceOrNoMatch                 1162.0m ± 0%   909.1m ± 0%  -21.76% (p=0.000 n=10)
BackendBlockTraceQL/mixedValNoMatch                  2.339 ± 0%    2.078 ± 0%  -11.16% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchAnd           455.0m ± 0%   193.9m ± 0%  -57.38% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchOr             16.00 ± 0%    16.00 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/count                            14.82 ± 0%    14.82 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/struct                           16.54 ± 0%    16.54 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/||                               14.91 ± 0%    14.91 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/mixed                            14.66 ± 0%    14.66 ± 0%        ~ (p=1.000 n=10) ¹
BackendBlockTraceQL/complex                          1.866 ± 1%    1.617 ± 2%  -13.32% (p=0.000 n=10)
geomean                                              4.586         3.802       -17.09%
¹ all samples are equal

                                                 │  before.txt   │              after.txt               │
                                                 │     B/op      │     B/op      vs base                │
BackendBlockTraceQL/spanAttValMatch                 29.74Mi ± 0%   29.77Mi ± 1%        ~ (p=0.739 n=10)
BackendBlockTraceQL/spanAttValNoMatch               1.554Mi ± 0%   1.538Mi ± 0%   -1.05% (p=0.000 n=10)
BackendBlockTraceQL/spanAttIntrinsicMatch           14.81Mi ± 1%   14.81Mi ± 0%        ~ (p=0.971 n=10)
BackendBlockTraceQL/spanAttIntrinsicNoMatch         1.112Mi ± 0%   1.095Mi ± 0%   -1.48% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttValMatch             316.8Mi ± 0%   317.3Mi ± 0%        ~ (p=0.052 n=10)
BackendBlockTraceQL/resourceAttValNoMatch           1.087Mi ± 0%   1.070Mi ± 0%   -1.53% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch       1.210Mi ± 0%   1.322Mi ± 0%   +9.21% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch#01    1.089Mi ± 0%   1.072Mi ± 0%   -1.52% (p=0.000 n=10)
BackendBlockTraceQL/traceOrMatch                   128.48Mi ± 1%   17.54Mi ± 0%  -86.35% (p=0.000 n=10)
BackendBlockTraceQL/traceOrNoMatch                 125.42Mi ± 1%   16.14Mi ± 1%  -87.13% (p=0.000 n=10)
BackendBlockTraceQL/mixedValNoMatch                 1.596Mi ± 0%   1.579Mi ± 0%   -1.04% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchAnd           1.089Mi ± 0%   1.073Mi ± 0%   -1.53% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchOr            2.020Mi ± 3%   2.100Mi ± 1%   +3.95% (p=0.000 n=10)
BackendBlockTraceQL/count                           231.3Mi ± 0%   231.4Mi ± 0%        ~ (p=1.000 n=10)
BackendBlockTraceQL/struct                          127.2Mi ± 3%   130.4Mi ± 3%   +2.52% (p=0.005 n=10)
BackendBlockTraceQL/||                              16.41Mi ± 0%   16.42Mi ± 0%        ~ (p=0.739 n=10)
BackendBlockTraceQL/mixed                           4.186Mi ± 0%   4.201Mi ± 0%   +0.34% (p=0.000 n=10)
BackendBlockTraceQL/complex                         1.148Mi ± 0%   1.132Mi ± 0%   -1.47% (p=0.000 n=10)
geomean                                             8.421Mi        6.751Mi       -19.84%

                                                 │  before.txt  │              after.txt              │
                                                 │  allocs/op   │  allocs/op   vs base                │
BackendBlockTraceQL/spanAttValMatch                 313.6k ± 0%   313.6k ± 0%        ~ (p=0.361 n=10)
BackendBlockTraceQL/spanAttValNoMatch               17.44k ± 0%   17.29k ± 0%   -0.85% (p=0.000 n=10)
BackendBlockTraceQL/spanAttIntrinsicMatch           118.5k ± 0%   118.5k ± 0%   +0.00% (p=0.001 n=10)
BackendBlockTraceQL/spanAttIntrinsicNoMatch         17.37k ± 0%   17.22k ± 0%   -0.86% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttValMatch             2.293M ± 0%   2.293M ± 0%        ~ (p=0.084 n=10)
BackendBlockTraceQL/resourceAttValNoMatch           17.40k ± 0%   17.25k ± 0%   -0.87% (p=0.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch       18.57k ± 0%   18.57k ± 0%        ~ (p=1.000 n=10)
BackendBlockTraceQL/resourceAttIntrinsicMatch#01    17.40k ± 0%   17.25k ± 0%   -0.87% (p=0.000 n=10)
BackendBlockTraceQL/traceOrMatch                   1107.9k ± 1%   162.1k ± 0%  -85.37% (p=0.000 n=10)
BackendBlockTraceQL/traceOrNoMatch                 1117.4k ± 1%   153.5k ± 0%  -86.26% (p=0.000 n=10)
BackendBlockTraceQL/mixedValNoMatch                 18.18k ± 0%   18.03k ± 0%   -0.83% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchAnd           17.43k ± 0%   17.28k ± 0%   -0.87% (p=0.000 n=10)
BackendBlockTraceQL/mixedValMixedMatchOr            24.19k ± 0%   24.19k ± 0%        ~ (p=0.636 n=10)
BackendBlockTraceQL/count                           1.476M ± 0%   1.476M ± 0%        ~ (p=0.753 n=10)
BackendBlockTraceQL/struct                          1.009M ± 1%   1.006M ± 1%        ~ (p=0.393 n=10)
BackendBlockTraceQL/||                              141.7k ± 0%   141.7k ± 0%   -0.00% (p=0.016 n=10)
BackendBlockTraceQL/mixed                           47.45k ± 0%   47.45k ± 0%   +0.00% (p=0.000 n=10)
BackendBlockTraceQL/complex                         17.78k ± 0%   17.63k ± 0%   -0.84% (p=0.000 n=10)
geomean                                             92.48k        74.18k       -19.79%
BenchmarkQueryRange 
                                                                          │ before_range.txt │          after_range.txt           │
                                                                          │      sec/op      │   sec/op     vs base               │
BackendBlockQueryRange/{}_|_rate()/3                                             410.4m ± 1%   406.8m ± 1%       ~ (p=0.063 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                   815.7m ± 3%   809.1m ± 4%       ~ (p=0.315 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                  556.1m ± 4%   554.8m ± 5%       ~ (p=0.529 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                           1.028 ± 2%    1.020 ± 2%       ~ (p=0.393 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                               950.0m ± 1%   968.1m ± 3%       ~ (p=0.143 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                           875.0m ± 3%   868.6m ± 1%       ~ (p=0.436 n=10)
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3        132.8m ± 3%   132.1m ± 2%       ~ (p=0.529 n=10)
BackendBlockQueryRange/{status=error}_|_rate()/3                                 105.2m ± 1%   105.5m ± 0%       ~ (p=0.481 n=10)
geomean                                                                          466.0m        464.9m       -0.24%

                                                                          │ before_range.txt │           after_range.txt           │
                                                                          │     MB_IO/op     │  MB_IO/op   vs base                 │
BackendBlockQueryRange/{}_|_rate()/3                                              14.64 ± 0%   14.64 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                    18.61 ± 0%   18.61 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                   14.95 ± 0%   14.95 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                           16.95 ± 0%   16.95 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                                17.45 ± 0%   17.45 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                            15.20 ± 0%   15.20 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3         14.95 ± 0%   14.95 ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{status=error}_|_rate()/3                                  15.65 ± 0%   15.65 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                                                           16.00        16.00       +0.00%
¹ all samples are equal

                                                                          │ before_range.txt │           after_range.txt            │
                                                                          │     spans/op     │  spans/op    vs base                 │
BackendBlockQueryRange/{}_|_rate()/3                                             2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                   2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                  2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                          2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                               2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                           2.553M ± 0%   2.553M ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3        503.7k ± 0%   503.7k ± 0%       ~ (p=1.000 n=10) ¹
BackendBlockQueryRange/{status=error}_|_rate()/3                                 93.82k ± 0%   93.82k ± 0%       ~ (p=1.000 n=10) ¹
geomean                                                                          1.379M        1.379M       +0.00%
¹ all samples are equal

                                                                          │ before_range.txt │          after_range.txt           │
                                                                          │     spans/s      │   spans/s    vs base               │
BackendBlockQueryRange/{}_|_rate()/3                                             6.220M ± 1%   6.275M ± 1%       ~ (p=0.063 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                   3.130M ± 3%   3.155M ± 4%       ~ (p=0.315 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                  4.590M ± 5%   4.601M ± 6%       ~ (p=0.529 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                          2.482M ± 3%   2.502M ± 2%       ~ (p=0.393 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                               2.687M ± 1%   2.637M ± 3%       ~ (p=0.143 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                           2.918M ± 3%   2.939M ± 1%       ~ (p=0.436 n=10)
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3        3.793M ± 3%   3.814M ± 2%       ~ (p=0.529 n=10)
BackendBlockQueryRange/{status=error}_|_rate()/3                                 891.5k ± 1%   889.7k ± 0%       ~ (p=0.481 n=10)
geomean                                                                          2.959M        2.966M       +0.24%

                                                                          │ before_range.txt │           after_range.txt            │
                                                                          │       B/op       │     B/op       vs base               │
BackendBlockQueryRange/{}_|_rate()/3                                           7.460Mi ±  0%   7.460Mi ±  0%  +0.00% (p=0.000 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                 8.843Mi ±  2%   8.842Mi ±  0%       ~ (p=0.172 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                8.188Mi ±  0%   8.188Mi ±  0%       ~ (p=0.305 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                        158.8Mi ± 14%   170.4Mi ± 10%       ~ (p=0.280 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                             106.3Mi ±  5%   105.8Mi ±  6%       ~ (p=0.566 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                         105.6Mi ±  5%   105.6Mi ±  7%       ~ (p=0.668 n=10)
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3      5.951Mi ±  0%   5.951Mi ±  0%  +0.00% (p=0.001 n=10)
BackendBlockQueryRange/{status=error}_|_rate()/3                               1.674Mi ±  0%   1.669Mi ±  0%       ~ (p=0.462 n=10)
geomean                                                                        17.69Mi         17.83Mi        +0.80%

                                                                          │ before_range.txt │          after_range.txt           │
                                                                          │    allocs/op     │  allocs/op   vs base               │
BackendBlockQueryRange/{}_|_rate()/3                                            237.2k ±  0%   237.2k ± 0%  +0.00% (p=0.000 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(name)/3                                  242.3k ±  0%   242.3k ± 0%       ~ (p=0.642 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.service.name)/3                 237.9k ±  0%   237.9k ± 0%  +0.00% (p=0.000 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.http.url)/3                         1.238M ± 11%   1.288M ± 4%       ~ (p=0.105 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(span.foo)/3                              983.2k ±  3%   983.2k ± 4%       ~ (p=0.343 n=10)
BackendBlockQueryRange/{}_|_rate()_by_(resource.foo)/3                          983.2k ±  2%   983.2k ± 3%       ~ (p=0.302 n=10)
BackendBlockQueryRange/{resource.service.name=`loki-ingester`}_|_rate()/3       63.38k ±  0%   63.38k ± 0%  +0.00% (p=0.000 n=10)
BackendBlockQueryRange/{status=error}_|_rate()/3                                37.84k ±  0%   37.84k ± 0%  +0.01% (p=0.000 n=10)
geomean                                                                         281.3k         282.7k       +0.50%

Which issue(s) this PR fixes:
Fixes n/a

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mdisibio
Change trace-level iterators to push predicates down for all queries …
75f5aa6 
…even when AllConditions=false, by making metadata second pass more specific
mapno
mapno approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mdisibio mdisibio enabled auto-merge (squash) July 30, 2024 16:27
@mdisibio mdisibio merged commit 6e9d93a into grafana:main Jul 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapno mapno mapno approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner

@annanay25 annanay25 Awaiting requested review from annanay25

@yvrhdn yvrhdn Awaiting requested review from yvrhdn yvrhdn is a code owner

@zalegrala zalegrala Awaiting requested review from zalegrala zalegrala is a code owner

@electron0zero electron0zero Awaiting requested review from electron0zero electron0zero is a code owner

@ie-pham ie-pham Awaiting requested review from ie-pham ie-pham is a code owner

@stoewer stoewer Awaiting requested review from stoewer stoewer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdisibio @mapno