-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow compaction disable per tenant #3965
Allow compaction disable per tenant #3965
Conversation
67ba83b
to
6d45fc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good. maybe just clarify Disabled -> CompactionDisabled? everything else is +1
e7cef91
to
736cbd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good so going to approve, but if we can sneak changelog/docs in would be good
What this PR does:
Here we plumb in an option to allow compaction to be disabled per tenant. This will be useful to perform certain operations on the backend which require compaction to be disabled for a period of time.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]