Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compaction disable per tenant #3965

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

zalegrala
Copy link
Contributor

@zalegrala zalegrala commented Aug 14, 2024

What this PR does:

Here we plumb in an option to allow compaction to be disabled per tenant. This will be useful to perform certain operations on the backend which require compaction to be disabled for a period of time.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@zalegrala zalegrala force-pushed the tempoCompactionDisablePerTenant branch from 67ba83b to 6d45fc2 Compare August 14, 2024 20:41
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good. maybe just clarify Disabled -> CompactionDisabled? everything else is +1

modules/compactor/compactor.go Outdated Show resolved Hide resolved
modules/compactor/compactor.go Outdated Show resolved Hide resolved
@zalegrala zalegrala force-pushed the tempoCompactionDisablePerTenant branch from e7cef91 to 736cbd9 Compare August 15, 2024 13:20
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good so going to approve, but if we can sneak changelog/docs in would be good

@zalegrala zalegrala merged commit 7dffd0e into grafana:main Aug 15, 2024
16 checks passed
@zalegrala zalegrala deleted the tempoCompactionDisablePerTenant branch August 15, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants