Tweak CPU and memory display on operational dashboard #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Memory and CPU metrics are reported per cgroup, so pods with more than one container have several lines. This change allows them to be distinguished.
These metrics are typically very low because the "pause" container is a piece of Kubernetes internals that sits and does nothing. Filtering them out of the display aids readability. Note in some Kubernetes installations the pause container is labled "POD", which was previously filtered out from the dashboard. See containerd/cri#922 for background on the name.
bboreham
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
|
|
|
@bboreham Please sign the CLA and we'll get this merged. |
joe-elliott
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add container name to Memory and CPU metrics. They are reported per cgroup, so pods with more than one container have several lines. This change allows them to be distinguished.
Also filter out 'pause' container - these metrics are typically very low because the "pause" container is a piece of Kubernetes internals that sits and does nothing. Filtering them out of the display aids readability.
Note in some Kubernetes installations the pause container is labled "POD", which was previously filtered out from the dashboard in #496. See containerd/cri#922 for background on the name.
Which issue(s) this PR fixes:
None
Checklist
CHANGELOG.mdupdated