Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare CI for our internal release train #828

Merged
merged 4 commits into from
Jul 20, 2021

Conversation

jvrplmlmn
Copy link
Contributor

This PR lays the groundwork to adopt an internal weekly release cycle. This simply adds an additional trigger to CI so it can build and push artifacts on r? and r?? branches, which are later consumed by our internal automation.

Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess @kvrhdn can give the signoff on this one since he has been working with you!

tools/image-tag Show resolved Hide resolved
tools/image-tag Show resolved Hide resolved
Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂 I just have some minor questions.

.drone/drone.yml Show resolved Hide resolved
tools/image-tag Show resolved Hide resolved
tools/image-tag Show resolved Hide resolved
This requires bash to be installed in the alpine/git image

docker run --rm -it --entrypoint /bin/sh alpine/git
/git # bash
/bin/sh: bash: not found
/git # apk --update --no-cache add bash
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.13/community/x86_64/APKINDEX.tar.gz
(1/2) Installing readline (8.1.0-r0)
(2/2) Installing bash (5.1.0-r0)
Executing bash-5.1.0-r0.post-install
Executing busybox-1.32.1-r6.trigger
OK: 27 MiB in 33 packages
/git # ^C
Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits 🙂 This is looking good, can someone with the necessary permission merge this for us? @annanay25 maybe?

@annanay25 annanay25 merged commit 1795cf1 into main Jul 20, 2021
@annanay25 annanay25 deleted the jvrplmlmn/internal-release-train branch July 20, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants