-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include simple e2e test to test searching #978
Conversation
2cd91bc
to
5f2d8bd
Compare
Are the |
It appears so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
definitely remove the stringPointer()
method. i will leave to @annanay25 to approve/merge, but it generally lgtm
5f2d8bd
to
77ea4bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the blind [0] deferences is kind of gorpy
I agree with joe this is kind of weird. how about we loop through all tags in every trace and search for them individually? might require that we make the tags/values unique
but honestly this whole test is
what else can we improve about this test?
In looking over what we're doing, I think there are a few improvements we could make to the tests overall. Since we are making a bunch of http calls and inspecting the response code, we could also inspect the output and such. In the vulture tests, we're validating the content against a fixture, and we could do something similar here. If some of the vulture code were moved out of |
90b7b90
to
23cdfd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @zelagrala, left one non-blocking comment.
23cdfd0
to
6024ebd
Compare
What this PR does:
Extend the
microservices
e2e test to include search functionality.Which issue(s) this PR fixes:
Fixes #925
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]