Synthetic Monitoring Probe and Check Resources and Data Sources #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Precheck for acceptance tests for cloud resources. This allows us to fail fast if GRAFANA_SM_ACCESS_TOKEN is unset.
Duplicate value check w/ incorrect value
inkel
approved these changes
Jun 24, 2021
|
Would it be possible to have the probe resource return the api token for the probe on creation? That would let us store it in vault or anywhere else to automatically provision the probe end-to-end. I realize that may be hard to do on subsequent reads, but maybe it doesn't need to? |
simple.tf and complex.tf didn't make sense because they are essentially the same. Instead resource.tf and resource_update.tf since the reason there is two is to check that update works properly. The template is also deleted in favor of the tfplugindocs default which will render resource.tf automatically.
|
Merging blocked due to tests failing. #231 should resolve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds resources:
Add data sources:
Testing
A "cloud" build tag was added to the top of the Synthetic Monitoring
_test.gofiles (// +build cloud). Therefore, CI in its current state will not run them. I've created an issue to capture the effort of enabling CI for these tests as a followup: #226.Documentation
Documentation was generated with
go generate. The resources have custom templates to allow the inclusion of multiple examples. I've created another issue to followup to use subcategories to group cloud resources together in navigation: #227.adapters.go
The addition of this file was inspired by https://github.com/paultyng/terraform-provider-unifi/blob/8601203944690676671871390d938ed5238a7f08/internal/provider/strings.go. It's a collection of functions for converting types. These should be useful for making resources and data sources more succinct.
schema.go
This was inspired by https://github.com/hashicorp/terraform-provider-google/blob/eb82ee95846c03976d7df3fbbb965f0ea8106d2b/google/datasource_helpers.go. These functions allow us to reuse resource schemas for data sources. This is instead of duplicating them. It's intended for general schema utilities like this that we can use throughout the provider.
Closes #198