Use the golangci-lint CI action

Replace the action with the official one, and also fixes chore linter
issues like deprecated `ioutil` usages.

.github/workflows/ci.yml

@@ -88,19 +88,27 @@ jobs:
       run: |
         go test -v -coverprofile="cover-profile.out" -short -race ./...
 
-  # From https://github.com/reviewdog/action-golangci-lint
   golangci-lint:
     name: runner / golangci-lint
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout code into the Go module directory
-        uses: actions/checkout@v2
-
-      - name: Run golangci-lint
-        uses: reviewdog/action-golangci-lint@v1
-        # uses: docker://reviewdog/action-golangci-lint:v1 # pre-build docker image
+      - name: Checkout code
+        uses: actions/checkout@v3
+        with:
+          fetch-depth: 0
+      - name: Install Go
+        uses: actions/setup-go@v3
+        with:
+          go-version: 1.19.x
+          check-latest: true
+      - name: Retrieve golangci-lint version
+        run: |
+          echo "Version=$(head -n 1 "${GITHUB_WORKSPACE}/.golangci.yml" | tr -d '# ')" >> $GITHUB_OUTPUT
+        id: version
+      - name: golangci-lint
+        uses: golangci/golangci-lint-action@v3
         with:
-          github_token: ${{ secrets.github_token }}
+          version: ${{ steps.version.outputs.Version }}          
 
   goreleaser-check:
     runs-on: ubuntu-latest

.golangci.yml

@@ -1,3 +1,5 @@
+# v1.50.1
+# Please don't remove the first line. It uses in CI to determine the golangci version
 linters-settings:
   errcheck:
     ignore: fmt:.*,io/ioutil:^Read.*

builder.go

@@ -17,7 +17,6 @@ package xk6
 import (
 	"context"
 	"fmt"
-	"io/ioutil"
 	"log"
 	"os"
 	"path"
@@ -109,7 +108,7 @@ func (b Builder) Build(ctx context.Context, outputFile string) error {
 	cmd := buildEnv.newCommand("go",
 		buildFlagsSlice...,
 	)
-	//dont add raceArg again if it already in place
+	// dont add raceArg again if it already in place
 	if b.RaceDetector && !strings.Contains(buildFlags, raceArg) {
 		cmd.Args = append(cmd.Args, raceArg)
 	}
@@ -213,7 +212,7 @@ func newTempFolder() (string, error) {
 		}
 	}
 	ts := time.Now().Format(yearMonthDayHourMin)
-	return ioutil.TempDir(parentDir, fmt.Sprintf("buildenv_%s.", ts))
+	return os.MkdirTemp(parentDir, fmt.Sprintf("buildenv_%s.", ts))
 }
 
 // versionedModulePath helps enforce Go Module's Semantic Import Versioning (SIV) by

environment.go

@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 	"html/template"
-	"io/ioutil"
 	"log"
 	"os"
 	"os/exec"
@@ -160,7 +159,7 @@ nextExt:
 	// we do this last so we get the needed versions from all the replacements and extensions instead of k6 if possible
 	mainPath := filepath.Join(tempFolder, "main.go")
 	log.Printf("[INFO] Writing main module: %s", mainPath)
-	err = ioutil.WriteFile(mainPath, buf.Bytes(), 0o600)
+	err = os.WriteFile(mainPath, buf.Bytes(), 0o600)
 	if err != nil {
 		return nil, err
 	}
@@ -210,7 +209,7 @@ func (env environment) writeExtensionImportFile(packagePath string) error {
 import _ %q
 `, packagePath)
 	filePath := filepath.Join(env.tempFolder, strings.ReplaceAll(packagePath, "/", "_")+".go")
-	return ioutil.WriteFile(filePath, []byte(fileContents), 0o600)
+	return os.WriteFile(filePath, []byte(fileContents), 0o600)
 }
 
 func (env environment) newCommand(command string, args ...string) *exec.Cmd {