Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install git #104

Merged
merged 1 commit into from
Jul 22, 2024
Merged

install git #104

merged 1 commit into from
Jul 22, 2024

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Jul 22, 2024 •
edited
Loading

In some circumstances go mod command needs git binary to download packages (e.g. when using private packages not provided by proxy.golang.org), but the Alpine-based golang image doesn't have git installed by default.

@pablochacin
install git
817ee58 
Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin pablochacin requested a review from a team as a code owner July 22, 2024 09:53
@pablochacin pablochacin requested review from szkiba and removed request for a team July 22, 2024 09:53
szkiba
szkiba approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablochacin pablochacin merged commit 145498c into master Jul 22, 2024
8 checks passed
@pablochacin pablochacin mentioned this pull request Jul 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szkiba szkiba szkiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablochacin @szkiba