Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't force latest k6 when building extensions #44

Merged
merged 4 commits into from
May 12, 2022
Merged

Don't force latest k6 when building extensions #44

merged 4 commits into from
May 12, 2022

Commits on May 11, 2022

  1. Don't force latest k6 when building extensions 

    an extension will always require k6 and a version of it. It makes little
sense to force newer version on users especially as we keep breaking
them and we need time to go fix them, but that can only happen after
release.

This still lets users specify the version (as latest for example) and
require the latest k6, it just isn't the default.
    @mstoykov
    mstoykov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    fa72d58 View commit details
    Browse the repository at this point in the history

  2. Fix any kind of go module replacements getting latest k6 

    This is a bit strange but it turns out that if you have replacements go
change how it resolves modules a bit and will try to get the latest
versions of some dependencies.

Also if you have one extension and you are building it from local
sources we would not run `go mod tidy` reliably. This doesn't really
matter in practice as we do run it almost every other command, but was
getting in the way of smaller fix.

Both of those are fixed with this commit and now we do definitely run
`go mod tidy` once we have requested all extensions and put down the
files needing them. And also only write a file requesting k6 directly at
the very end so it only try to get it's version at this point - and at
that point we should already have requested through an extension.
    @mstoykov
    mstoykov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    1c4e786 View commit details
    Browse the repository at this point in the history

  3. Fix k6 version not being taken into account anymore 

    This was as there was *possibly* nothing requesting k6 at the time it
was setup. Replaces on the other hand stick so XK6_K6_REPO always
worked.
    @mstoykov
    mstoykov committed May 11, 2022
    Configuration menu
    Copy the full SHA
    94b9ca8 View commit details
    Browse the repository at this point in the history

  4. Update environment.go 

    Co-authored-by: Ivan Mirić <[email protected]>
    @mstoykov
    mstoykov and Ivan Mirić committed May 11, 2022
    Configuration menu
    Copy the full SHA
    20fdc08 View commit details
    Browse the repository at this point in the history