Add Dockerfile and publish image to container registries #62
Conversation
imiric
force-pushed
the
feat/docker-image
branch
from
0e5a6f2
to
78b2ab7
Compare
|
It would probably be good to add some CI tests for the image, right? I can do that later today. |
This allows using xk6 via Docker, without having to setup a local Go environment or install xk6. Unfortunately, file permissions with mounted volumes are still an issue[1], without a simple, native fix. fixuid[2] seems to be the modern solution to this, and works well from my tests. Part of #8 [1]: moby/moby#7198 [2]: https://github.com/boxboat/fixuid
imiric
force-pushed
the
feat/docker-image
branch
from
8a2c599
to
70d993f
Compare
|
I'm not quite finished with this, as I want to invite people on macOS and Windows using Docker Desktop to try this out, and see if it works for them as well. 🤞 And while I tested the Docker release to GHCR in my fork, we also need to push the image to Docker Hub, so I'll need some help from DevOps, or whoever is managing the Grafana org to create the initial package we can push to. |
The grafana/xk6 image isn't published yet, which I'll do after the Dockerfile is approved. In the meantime, you can build it with e.g.: docker build -t test/xk6 .
imiric
force-pushed
the
feat/docker-image
branch
from
8416806
to
81c43f1
Compare
imiric
force-pushed
the
feat/docker-image
branch
from
81c43f1
to
3b5fe53
Compare
|
OK, this should be done now. We confirmed the image works on macOS and Windows, and I updated the instructions. I also added pushing to Docker Hub. grafana/xk6 is now available, but I haven't yet tested pushing to it. I added the secrets to the repo, and mostly copied the commands from the k6 workflow, so it should work once this is merged. 🤞 |
imiric
changed the title
| ``` | ||
|
|
||
| For the native Windows binary if you're using cmd.exe: | ||
| ```batch |
There was a problem hiding this comment.
| ```batch | |
| ```bash |
There was a problem hiding this comment.
Actually, this is Windows Batch file syntax. I wasn't sure if cmd.exe or batch would work, but batch seems to highlight some syntax, so it's good enough. 🤷♂️
imiric
force-pushed
the
feat/docker-image
branch
from
3b5fe53
to
875f6e1
Compare
|
Thanks for the reviews and testing, everyone! 🙇 In the latest force push I just split the Docker steps for GHCR and Docker Hub, as they're in the k6 workflow file, to avoid breaking publishing on one registry if the other is down. I'll merge this, and make a release soon (after #60), so we can test the full release process. 🤞 |
This allows using xk6 via Docker, without having to setup a local Go environment or install xk6.
Unfortunately, file permissions with mounted volumes are still an issue, without a simple, native fix. fixuid seems to be the modern solution to this, and works well from my tests.
The
grafana/xk6image isn't published yet, which will be done after this is merged, and we make a new release. I've tested publishing to GHCR in my fork, which worked fine.In the meantime, you can build it with e.g.
docker build -t test/xk6 ..Closes #8