Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use alpine as base image #86

Merged
merged 2 commits into from
Jan 29, 2024
Merged

use alpine as base image #86

merged 2 commits into from
Jan 29, 2024

Conversation

pablochacin
Copy link
Collaborator

@pablochacin pablochacin commented Jan 29, 2024

Change the base image to reduce the attack surface and minimize the exposure.

Fixes: #77

Results of image scanning with trivy (after update in #85):

xk6 (debian 12.4)
=================
Total: 360 (UNKNOWN: 3, LOW: 247, MEDIUM: 75, HIGH: 34, CRITICAL: 1)

alpine-based image:

xk6:alpine-3.18 (alpine 3.18.6)
===============================
Total: 0 (UNKNOWN: 0, LOW: 0, MEDIUM: 0, HIGH: 0, CRITICAL: 0)

Note: There's a newer version of alpine based image (3.19.1) but trivy issues a warning when scanning it:

2024-01-29T11:55:10.355Z        WARN    This OS version is not on the EOL list: alpine 3.19

Signed-off-by: Pablo Chacin <[email protected]>
@pablochacin pablochacin requested a review from a team as a code owner January 29, 2024 11:53
Copy link
Contributor

@szkiba szkiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile Outdated Show resolved Hide resolved
Co-authored-by: Mihail Stoykov <[email protected]>
@pablochacin pablochacin merged commit 7028164 into master Jan 29, 2024
8 checks passed
This was referenced Jan 29, 2024
@pablochacin
Copy link
Collaborator Author

Reverted in #87 due to concerns in breaking changes due to alpine not using standard clib and lack of some tools that may be required by images that use xk6 image as a base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change base image for xk6 image
3 participants