Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSP taglib syntax error (extra comma) fails silently #25

Open
gschueler opened this issue May 11, 2018 · 0 comments
Open

GSP taglib syntax error (extra comma) fails silently #25

gschueler opened this issue May 11, 2018 · 0 comments
Assignees

Comments

@gschueler
Copy link

If an extra comma , is present in use of a taglib tag, it is flagged as a syntax error by IDEA, but seems to be ignored by gsp compiler, causing the remaining attributes of the tag to be silently dropped.

e.g. we had <g:message code="by.you", default="by you"/> (note extra comma after code attribute) however the by.you message did not exist, but was still rendered as by.you instead of the default. The extraneous comma was the culprit.

Steps to Reproduce

  1. Use invalid syntax <g:message code="missing.message", default="default value"/> (see extra comma)

Expected Behaviour

The gsp should not render due to invalid syntax (extra comma ,)

Actual Behaviour

The g:message tag works but ignores attributes after the comma. The text "missing.message" is displayed.

Environment Information

  • Operating System: macosX/linux
  • Grails Version: 2.5.6/3.3.5
  • JDK Version: 1.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants