-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support POST variant of validators api #28
Comments
3 tasks
SifraiTeam
pushed a commit
that referenced
this issue
Jun 22, 2024
POST /eth/v1/beacon/states/{state_id}/validator_balances looks similar but was not requested in the issue. The API specification does not explicitly say if it has the same semantics as the GET endpoint.
SifraiTeam
pushed a commit
that referenced
this issue
Jul 12, 2024
POST /eth/v1/beacon/states/{state_id}/validator_balances looks similar but was not requested in the issue. The API specification does not explicitly say if it has the same semantics as the GET endpoint.
hey @nflaig, did you have the chance to test this? Fix has been merged to develop. |
Confirmed the fix by running the following config: participants:
- el_type: geth
el_image: ethereum/client-go:stable
cl_type: grandine
cl_image: ethpandaops/grandine:develop-minimal
vc_type: lodestar
vc_image: nflaig/lodestar:post-validators
vc_extra_params:
- --http.requestWireFormat=ssz
count: 4
network_params:
genesis_delay: 60
num_validator_keys_per_node: 64
additional_services:
- assertoor
- dora
snooper_enabled: true
disable_peer_scoring: true
assertoor_params:
image: "ethpandaops/assertoor:master"
run_stability_check: false
run_block_proposal_check: false
tests:
- https://raw.githubusercontent.com/ethpandaops/assertoor-test/2a45f2f78dd2c336ac99bf15e61edc076f15ce67/assertoor-tests/block-proposal-check.yaml Thanks for the fix 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are looking into using the POST variant of validators api (postStateValidators) but during interop testing I noticed Grandine returns a 405 error. I am guessing you have not yet implemented it.
I wanna make sure Lodestar VC is compatible with Grandine, as a workaround, we can also retry the GET variant of the API if we receive a 405 error.
Let me know if you are planning to implement this soon, can also hold off on merging this on our side.
The text was updated successfully, but these errors were encountered: