Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing to the TROUBLESHOOTING #505

Closed
ppKrauss opened this issue Jul 8, 2017 · 2 comments
Closed

Contributing to the TROUBLESHOOTING #505

ppKrauss opened this issue Jul 8, 2017 · 2 comments

Comments

@ppKrauss
Copy link
Contributor

ppKrauss commented Jul 8, 2017

This issue is a guide and a place to discuss the contents of the TROUBLESHOOTING.md.

There are only three rules (best practices) to add new items:

  1. Edit it formating as described below, with "subject group section" and "problem subsection".

  2. Cite the "motivation" from popular or frequent problem-report, at postgraphql/issues or stackoverflow. If there are no documented motivation, perhaps not need to add a TROUBLESHOOTING new item.

  3. To be concise: describe the problem with precision, and solution details when it it is short and oportune (the solution must be a link when is to long).

Format:

----

## subject group X
...

### problem Y1 at subject X
...

Details at ...

### problem Y2 at subject X
...

Details at ...
@benjie
Copy link
Member

benjie commented Jul 8, 2017

  1. Use neutral and respectful language, e.g. "You may sometimes meet an issue with ..." rather than "You may sometimes meet a really annoying issue with ..."

benjie added a commit that referenced this issue Aug 15, 2018
@benjie
docs(TROUBLESHOOTING): add instructions to file
289861d 
Fixes #505
@benjie benjie mentioned this issue Aug 15, 2018
Merged
@benjie
Copy link
Member

benjie commented Aug 15, 2018

Thanks for this @ppKrauss; since there's not been any more comments here I've moved the instructions to the TROUBLESHOOTING file itself, as a comment.

@benjie benjie closed this as completed Aug 15, 2018
benjie added a commit that referenced this issue Aug 15, 2018
@benjie
docs(TROUBLESHOOTING): add instructions to file (#833)
0354e6f 
Fixes #505
benjie added a commit that referenced this issue Jan 27, 2020
@benjie @singingwolfboy @ab-pm
feat: selectively back-port fixes from master (#594)
9536750 
* chore(tsdoc): enable TSDoc linting (#577)

* chore: add tests for GRAPHILE_TURBO (#582)

* chore(types): export GraphileResolverContext

* chore(release): use yarn commands

* feat(watch): manual schema reload notification (#583)

* chore(git): ignore .env file (#590)

* chore(tests): use Jest GraphQL schema serializer (#589)

* feat(omit) take "many" on constraints into account (#565)

* feat(omit) take "many" on constraints into account

Closes #505.

* move `@omit many` constraint condition to "many" relations only

and simplify the conditions a bit, outdenting `makeField` by one level

Co-authored-by: Benjie Gillam <[email protected]>

* feat(pg): support non-scalar range values (#591)

Co-authored-by: Benjie Gillam <[email protected]>

* Fix issues after rebase

* More reliable?

Co-authored-by: David Baumgold <[email protected]>
Co-authored-by: Andreas Bergmaier <[email protected]>
benjie added a commit that referenced this issue Jan 28, 2020
@ab-pm @benjie
feat(omit) take "many" on constraints into account (#565)
86b9675 
* feat(omit) take "many" on constraints into account

Closes #505.

* move `@omit many` constraint condition to "many" relations only

and simplify the conditions a bit, outdenting `makeField` by one level

Co-authored-by: Benjie Gillam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjie @ppKrauss