We should be sending a 401 status code not a 403 on expired token. #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this issue when using the authMiddleware from https://github.com/nodkz/react-relay-network-layer
authMiddleware provides the following functionality
However postgraphql only sends a 403 status code. I was going to create a pull request for authMiddleware but after a bit of research I can see that postgrapqhl should really be sending a 401 in this case*.
Many people will be using authMiddleware with Relay, so this could make things easier all
*https://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses
*https://www.loggly.com/blog/http-status-code-diagram/