Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pgsettings): Only use settings of type string or number #589

Merged
merged 4 commits into from
Nov 1, 2017
Merged

feat(pgsettings): Only use settings of type string or number #589

merged 4 commits into from
Nov 1, 2017

Commits on Sep 27, 2017

  1. feat(pgsettings): Convert falsy settings to null instead of strings 

    For example, instead of an undefined pgSetting becoming "undefined" turn it into null so set_config can still accept it
    Sam Kvale committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    b60fa7f View commit details
    Browse the repository at this point in the history

  2. feat(pgsettings): Ignore undefined an null pgSettings and throw for o… 

    …bject types
    Sam Kvale committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    ed65410 View commit details
    Browse the repository at this point in the history

  3. feat(pgsettings): Throw error for boolean values

    Sam Kvale committed Sep 27, 2017
    Configuration menu
    Copy the full SHA
    5c74389 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2017

  1. lint(tests): Add a missing comma

    Sam Kvale committed Oct 30, 2017
    Configuration menu
    Copy the full SHA
    39677b0 View commit details
    Browse the repository at this point in the history